Opened 5 years ago
Closed 14 months ago
#965 closed enhancement (wontfix)
Refactor XMLTester operation dispatch code
| Reported by: | mdavis | Owned by: | strk |
|---|---|---|---|
| Priority: | minor | Milestone: | 3.11.0 |
| Component: | XML Tests | Version: | 3.6.2 |
| Severity: | Unassigned | Keywords: | |
| Cc: |
Description
The XMLTester code has some defects due to poor code architecture:
- Not all functions are timed
- A lot of code duplication
- Hard to reuse code which dispatches to oeprations
These can be mitigated by refactoring the operation dispatch code to use either an abstract class for Operation (with concrete classes for each op / optype), OR a more C-style approach using polymorphism based on function pointers (yuck)
Change History (3)
comment:1 by , 3 years ago
| Milestone: | → 3.10.0 |
|---|
comment:2 by , 3 years ago
| Milestone: | 3.10.0 → 3.11.0 |
|---|
comment:3 by , 14 months ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Doesn't seem worth making sweeping changes to what is pretty stagnant code at this point. Should we change our minds about that, starting points can be found at https://github.com/libgeos/geos/compare/main...dbaston:libgeos:xmltester-refactor?expand=1 or in geosop.
Note:
See TracTickets
for help on using tickets.
Retargeting in prep for GEOS 3.10.0 release