Opened 18 years ago

Last modified 16 years ago

#96 closed defect (not a bug)

UniqueCoordinateArrayFilter should take const ref

Reported by: mloskot Owned by: mateusz@…
Priority: major Milestone:
Component: Core Version: 3.0.0
Severity: Content Keywords: imported, phpbugtracker
Cc:

Description (last modified by mloskot)

Current verson of the UniqueCoordinateArrayFilter constructor is: 

UniqueCoordinateArrayFilter(geom::Coordinate::ConstVect& target) : pts(target) {}

ConstVect can be safely passed by const-reference, because pts(target) calls copy constructor. Const-reference will make the API more clear.

Change History (2)

comment:1 by mateusz@…, 18 years ago

Resolution: none → not a bug 
I definitely have to take some break.

It can't be passed by const-ref, that'c obvious now, after I noticed the target:
geom::Coordinate::ConstVect &pts

I'm sorry for this mistake.

comment:2 by mloskot, 16 years ago

Description: modified (diff)
Milestone: imported
Priority: 2 → major
Reporter: changed from mateusz@… to mloskot
Note: See TracTickets for help on using tickets.