Regress failures on debbie and gitlab-ci on InteriorPointAreaPerfTest

[robe]

The other bots seem to be okay, but both debbie and gitlab-ci are failing with the same error as a result of this commit:

Commit 314960229dc44d5379aed57aed94c5190384c883 by gitea

Add InteriorPoint Area perf test, Profile enhancement (#63)

Error is ​https://debbie.postgis.net/job/GEOS_Master/472/consoleFull ​https://gitlab.com/geos/libgeos/-/jobs/162419404

make[3]: Entering directory '/var/lib/jenkins/workspace/geos/branches/3.8'
! find . -name '*.cpp' -o -name '*.h' | \
	grep -v tests/xmltester/tinyxml | \
	grep -v include/geos/algorithm/ttmath | \
	xargs grep -n '[[:space:]]$'
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:53:        std::unique_ptr<Polygon> sinePoly = 
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:83:    void 
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:87:        cout << "SineStar: origin: (" 
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:88:                << ORG_X << ", " << ORG_Y 
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:90:                << "  # arms: " << N_ARMS 
./tests/perf/algorithm/InteriorPointAreaPerfTest.cpp:91:                << "  arm ratio: " << ARM_RATIO 
make[3]: *** [Makefile:933: check-local] Error 1
make[3]: Leaving directory '/var/lib/jenkins/workspace/geos/branches/3.8'
make[2]: *** [Makefile:771: check-am] Error 2
make[2]: Leaving directory '/var/lib/jenkins/workspace/geos/branches/3.8'
make[1]: *** [Makefile:477: check-recursive] Error 1
make[1]: Leaving directory '/var/lib/jenkins/workspace/geos/branches/3.8'
make: *** [Makefile:773: check] Error 2
Build step 'Execute shell' marked build as failure
IRC notifier plugin: Sending notification to: #postgis-activity
Finished: FAILURE

[mdavis]

Is this an astyle thing? I will look into it ASAP - but am still learning all the various permutations of buildchain, so might take a while.

[dbaston]

Yes, it's just a check for trailing spaces. Probably only incorporated into autotools builds.

[mdavis]

Right... and I'm not using autotools buildchain (yet). And there is indeed some trailing spaces.

[mdavis]

All looks good now.

[robe]

dbaston but how come travis didn't pick up on it. It does autotools checks too no?

[robe]

yap looks good. See greens everywhere now.

[dbaston]

robe: You're right; I'm not sure why it didn't fail on Travis.

​https://travis-ci.com/libgeos/geos/jobs/178249759#L4296