GeometryFactory.cpp:750:1: warning: control reaches end of non-void function on windows cmake

[robe]

I'm seeing this warning on winnie's 32-bit and 64-bit runs. Not sure why I am not seeing it on the other bots.

E:/jenkins/geos/branches/3.8cmake/src/geom/GeometryFactory.cpp: In member function 'geos::geom::Geometry* geos::geom::GeometryFactory::buildGeometry(const std::vector<geos::geom::Geometry*>&) const':
E:/jenkins/geos/branches/3.8cmake/src/geom/GeometryFactory.cpp:750:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

This is building against GCC 4.8.3 and GCC 4.8.1.

I presume because it's just doing an assert rather than returning something so warning seems valid to me.

[robe]

I checked to see why I'm not getting the notice in 3.7 run, it appears in 3.8 we took ou the - return geom0->clone(); that is the catch all when nothing returns.

Aside from that the buildGeometry seems to have been considerably rewritten.

[robe]

Reopened the pull request at - ​https://github.com/libgeos/geos/pull/129 that triggered this. Was a result of fixing #929

[Algunenano]

This was addressed by ​https://github.com/libgeos/geos/commit/3d81f71d2984cc98c543a9eeccbee12be2769686