MarkupSTL.cpp - always true comparison

[mloskot]

g++ with -pedantic option reports following warning that may significantly influence logic of this code:

/home/mloskot/dev/geos/_cvs/geos/tests/xmltester/markup/MarkupSTL.cpp:884: 
 warning: comparison is always true due to limited range of data type

Here is this comparison:

int nEndCDATA = m_strDoc.find( "]]>",
                  token.nNext );
if ( (unsigned int)nEndCDATA != string::npos
&& nEndCDATA < m_aPos[iPos].nEndL )
{
   return m_strDoc.substr(token.nL+9,
          nEndCDATA-token.nL-9 );
}

[strk]

warning: comparison is always true due to limited range of data type

int nEndCDATA = m_strDoc.find( "]]>", token.nNext ); if ( (unsigned int)nEndCDATA != string::npos && nEndCDATA < m_aPos[iPos].nEndL )

Does casting to 'string::size_type' instead of 'unsigned int' fix the problem ?

[mloskot]

Patch fixing compilation warnings thrown by GCC 4.3.x

[mloskot]

Sandro,

More or less. See MarkupSTL_cpp-ticket-92.patch for all fixes necessary to silent GCC.

[strk]

Committed, thanks.