#804 closed defect (fixed)
tut_result.hpp needs includes for getpid
| Reported by: | goatbar | Owned by: | mloskot |
|---|---|---|---|
| Priority: | major | Milestone: | 3.6.2 |
| Component: | Default | Version: | 3.6.0 |
| Severity: | Unassigned | Keywords: | |
| Cc: |
Description
It would be good to also wrap parts of tut_result.hpp in HAVE_SYS_TYPES_H, HAVE_UNISTD, and/or TUT_USE_POSIX. e.g. like tut_console_reporter.hpp
-
geos/geos-3.6.1/tests/unit/tut/tut_result.hpp
a b 2 2 #define TUT_RESULT_H_GUARD 3 3 4 4 #include <string> 5 #include <sys/types.h> 6 #include <unistd.h> 5 7 6 8 namespace tut 7 9 {
Change History (14)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Looks like this was fixed upstream in 2015
https://github.com/mrzechonek/tut-framework/commit/1ad24b0719b34fc8b5b65121c138328971fc4f08
comment:3 by , 7 years ago
| Owner: | changed from to |
|---|
comment:4 by , 7 years ago
| Milestone: | 3.7.0 → 3.6.2 |
|---|
comment:5 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in svn-3.6: https://git.osgeo.org/gogs/geos/geos/commit/17e0d841b5f433037c7f8a00855ea7a97a3bac1f
Fixed in svn-trunk: https://git.osgeo.org/gogs/geos/geos/commit/ee134e7af15898a2cc6631d046851b50523cf437
(p.s. I have no idea if Trac automatically recognises Fixes #XXX and updates tickets)
comment:6 by , 7 years ago
Trac should recognize "Fixes #xxxx" in commit logs, yes. And I think you can reference commits with something like this: [17e0d84/git]
comment:7 by , 7 years ago
Ok the commit log parsing isn't working and the commit reference link I forgot how to make it, let's please file a ticket for the ticket update via commit log, must be a non-working git hook
comment:8 by , 7 years ago
Ok this works for commit reference: changeset:17e0d84/git
The syntax with [17e0d84/git] does not. I filed an upstream ticket about this: https://trac.edgewall.org/ticket/12760
comment:9 by , 7 years ago
For the record, using at least 8 characters in this TracLink form works: [17e0d841/git] See https://trac.edgewall.org/ticket/11992#comment:10
comment:10 by , 7 years ago
Mateusz I've updated the git post-receive hook so that hopefully now ticket updates via commit logs work. If you still find them to be non-working please file a ticket either here on trac OR on the now-under-git hooks repo: https://git.osgeo.org/gogs/geos/geos-git-hooks.git (private)
TUT is a local copy of this upstream: http://mrzechonek.github.io/tut-framework/
Could you report the bug there, and then we pull a copy when ready ?