Geos-php extenstion, tmp undeclared while compiling

[KayMadejski]

While compiling latest trunk:

php/geos.c: In function 'Gen_create_obj':
php/geos.c:174:50: error: 'tmp' undeclared (first use in this function)

I've just changed "(void*) &tmp" to "NULL" and it compiled, but I'm in no position to say if it's ok.

I've found possible relevant info: ​http://stackoverflow.com/questions/14105529/writing-a-c-extension-for-php-5-4-example-code-is-obsolete

[strk]

What version of PHP are you building against ? Did "make check" run under php dir work fine ? If so, I'll commit :)

[strk]

I've just tried with php-5.3.2 and I get this error on "make check":

Fatal error: Call to undefined function hex2bin() in /home/strk/src/geos/libgeos-trunk/php/test/test.php on line 2193

[strk]

It looks like hex2bin requires 5.4.0+, so that's an unrelated issue (but worth fixing) ​http://php.net/manual/it/function.hex2bin.php

[strk]

Added replacement, tests pass now with 5.3.2 too. Committed as r4027 in trunk (3.5.0) and r4028 in 3.4 branch (3.4.3)

[strk]

Ticket retargeted after milestone deleted