Can't build using cmake with tar ball

[robe]

I verified I can build from the tagged SVN http://trac.osgeo.org/geos/browser/tags/3.4.0 but tar ball I created fails with below. It's almost as if the CMAKE config is relying on SVN.

-- Found Subversion: C:/ming64gcc48/msys/bin/svn.exe (found version "1.6.17")
CMake Error at c:/ming64gcc48/cmake-2.8.11-win32-x86/share/cmake-2.8/Modules/Fin
dSubversion.cmake:83 (message):
  Command "C:/ming64gcc48/msys/bin/svn.exe info
  C:/ming64gcc48/projects/geos/geos-3.4.0" failed with output:

  svn: 'C:\ming64gcc48\projects\geos\geos-3.4.0' is not a working copy

Call Stack (most recent call first):
  CMakeLists.txt:249 (Subversion_WC_INFO)
  CMakeLists.txt:257 (GET_SVN_REVISION)


-- Generating revision header C:/ming64gcc48/projects/geos/geos-3.4.0/geos_svn_r
evision.h
Can't fetch local revision (neither .svn nor .git found)
Not updating existing rev file at GEOS_SVN_REVISION
-- Enable GEOS Unit Tests build - ON
-- Enable GEOS XML Tester build - ON
-- Enable GEOS large geometry tests build - ON
-- CMake 2.8.11 successfully configured geos using MSYS Makefiles generator
-- Configuring incomplete, errors occurred!

[robe]

Okay I've narrowed down the issue to the SVN check

MACRO (GET_SVN_REVISION)
   FIND_PACKAGE(Subversion)
   IF(SUBVERSION_FOUND)
      Subversion_WC_INFO(${PROJECT_SOURCE_DIR} Project)
      # MESSAGE("Current revision is ${Project_WC_REVISION}")
      # Subversion_WC_LOG(${PROJECT_SOURCE_DIR} Project)
      # MESSAGE("Last changed log is ${Project_LAST_CHANGED_LOG}")
   ENDIF()
ENDMACRO(GET_SVN_REVISION)

If I remark out the call to it on line 257 of outter CMakeLists.txt the tar compiles fine.

So its a matter of changing this macro to ignore if its not an SVN tree.

I also notice the outter CMakeLists.txt has 3.4.0 hardcodings. It would be nice if it could just read it rather than hardcoding. Until then, I'll just add not to HOW_TO_RELEASE.

[robe]

fixed for 3.4 branch at r3888

[robe]

fixed for 3.5 (trunk) at r3889

approach largely copied from ​http://stackoverflow.com/questions/17451226/cmake-how-to-get-subversion-revision-but-not-to-fail-if-we-made-an-export