Ticket #61 (closed defect: fixed)

Opened 7 years ago

Last modified 4 years ago

Ambiguous symbols - simple solution

Reported by: mloskot Owned by: mloskot
Priority: 1 Milestone:
Component: Core Version: svn-trunk
Severity: Annoyance Keywords: imported,phpbugtracker
Cc:

Description (last modified by mloskot) (diff)

This is a very simple solution for ambiguous symbols introduced in report:

#57 - Class naming changes proposal

As we talked today with strk, the #57 requires wider discussion, so for now I suggest to use simple solution - qualified name like:

using namespace geos;
//...
geom::Polygon

Example of error send by VC++ 8.0:

error C2872: 'Polygon' : ambiguous symbol	geossourceoperationpredicateRectangleIntersects.cpp 131

Simple fix is in the patch attached to this report.

Attachments

operation-predicate-full-path-of-polygon-mloskot-20060319.3.patch Download (1.9 KB) - added by mateusz@… 7 years ago.
Generated with cvs diff -U2

Change History

Changed 7 years ago by mateusz@…

Sorry, I can not provide patch at this moment because I've made some other changes already (with patches).
So, I have to wait for strk to apply previous patches
and then I'll generate new for this report.

Changed 7 years ago by strk@…

I'm ok with using geom::Polygon, if you feel like
patching all those files

Changed 7 years ago by mateusz@…

OK, I'll fix it during the weekend.
You can assign me to this report, to not to forget about it :-)

Changed 7 years ago by strk@…

assigned :)

Changed 7 years ago by mateusz@…

Fixed in patch attached.

This patch applies fully qualified name to ambiugous classes, so Polygon is changed to geos::geom::Polygon or geom::Polygon (when using namespace geos; directive is used).

Please, close this report after patch will be applied.

Changed 7 years ago by mateusz@…

Generated with cvs diff -U2

Changed 7 years ago by mateusz@…

  • resolution changed from none to fixed

Changed 5 years ago by mloskot

  • status changed from closed to reopened
  • description modified (diff)
  • reporter changed from mateusz@… to mloskot
  • version changed from 3.0.0 to svn-trunk
  • milestone imported deleted
  • resolution fixed deleted

Changed 5 years ago by mloskot

  • owner changed from mateusz@… to mloskot
  • status changed from reopened to new

Changed 5 years ago by mloskot

  • status changed from new to assigned

Changed 5 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

Changed 5 years ago by mloskot

  • milestone set to 3.0.0

Changed 4 years ago by anonymous

  • milestone 3.0.0 deleted

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.