Opened 18 years ago

Closed 16 years ago

Last modified 15 years ago

#61 closed defect (fixed)

Ambiguous symbols - simple solution

Reported by: mloskot Owned by: mloskot
Priority: 1 Milestone:
Component: Core Version: main
Severity: Annoyance Keywords: imported, phpbugtracker
Cc:

Description (last modified by mloskot)

This is a very simple solution for ambiguous symbols introduced in report:

#57 - Class naming changes proposal

As we talked today with strk, the #57 requires wider discussion, so for now I suggest to use simple solution - qualified name like:

using namespace geos;
//...
geom::Polygon

Example of error send by VC++ 8.0:

error C2872: 'Polygon' : ambiguous symbol	geossourceoperationpredicateRectangleIntersects.cpp 131

Simple fix is in the patch attached to this report.

Attachments (1)

operation-predicate-full-path-of-polygon-mloskot-20060319.3.patch (1.9 KB ) - added by mateusz@… 18 years ago.
Generated with cvs diff -U2

Download all attachments as: .zip

Change History (13)

comment:1 by mateusz@…, 18 years ago

Sorry, I can not provide patch at this moment because I've made some other changes already (with patches).
So, I have to wait for strk to apply previous patches
and then I'll generate new for this report.

comment:2 by strk@…, 18 years ago

I'm ok with using geom::Polygon, if you feel like
patching all those files

comment:3 by mateusz@…, 18 years ago

OK, I'll fix it during the weekend.
You can assign me to this report, to not to forget about it :-)

comment:4 by strk@…, 18 years ago

assigned :)

comment:5 by mateusz@…, 18 years ago

Fixed in patch attached.

This patch applies fully qualified name to ambiugous classes, so Polygon is changed to geos::geom::Polygon or geom::Polygon (when using namespace geos; directive is used).

Please, close this report after patch will be applied.

by mateusz@…, 18 years ago

Generated with cvs diff -U2

comment:6 by mateusz@…, 18 years ago

Resolution: nonefixed

comment:7 by mloskot, 16 years ago

Description: modified (diff)
Milestone: imported
Reporter: changed from mateusz@… to mloskot
Resolution: fixed
Status: closedreopened
Version: 3.0.0svn-trunk

comment:8 by mloskot, 16 years ago

Owner: changed from mateusz@… to mloskot
Status: reopenednew

comment:9 by mloskot, 16 years ago

Status: newassigned

comment:10 by mloskot, 16 years ago

Resolution: fixed
Status: assignedclosed

comment:11 by mloskot, 16 years ago

Milestone: 3.0.0

comment:12 by (none), 15 years ago

Milestone: 3.0.0

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.