Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#529 closed defect (invalid)

SimpleSnapRounder performs bogus noding

Reported by: strk Owned by: geos-devel@…
Priority: major Milestone: 3.4.0
Component: Default Version: main
Severity: Unassigned Keywords: history
Cc:

Description

I've committed a GeometryNoder class with r3593 with which doing some noding tests. If I try to use SimpleSnapRounder noder rather than the IteratedNoder (or SimpleNoder) I get a completely wrong answer on the simpest case:

LINESTRING(0 0, 10 10, 10 0, 0 10)

There's something deeply wrong in the code and the whole Noding interface is overly confusing (probably due to memory management not correctly ported).

Change History (3)

comment:1 by strk, 12 years ago

The problem here was with misuse. SimpleSnapRounder, as all snap-rounding noders using HotPixel class, can only work with a FIXED PrecisionModel. FLOATING precision models break HotPixel and thus all its users.

Will leave this ticket open until HotPixel is equipped with a control to throw IllegalArgumentException on a 0 scale.

comment:2 by strk, 12 years ago

Resolution: invalid
Status: newclosed

r3612 adds an assertion in HotPixel

comment:3 by robe, 11 years ago

Keywords: history added
Note: See TracTickets for help on using tickets.