Ticket #500 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

default initialization of an object of const type 'const geos::operation::overlay::OverlayNodeFactory' requires a user-provided default constructor

Reported by: hobu Owned by: geos-devel@…
Priority: minor Milestone: 3.3.2
Component: Default Version: 3.3.1
Severity: Unassigned Keywords:
Cc:

Description

clang reports: 

OverlayNodeFactory.cpp:31:33: error: default initialization of an object of const type 'const geos::operation::overlay::OverlayNodeFactory' requires a user-provided default
      constructor

Attachments

OverlayNodeFactory_singleton.patch Download (0.7 KB) - added by strk 5 months ago.

Change History

Changed 5 months ago by strk

OverlayNodeFactory? does have a user-provided default constructor. Only it is inlined (it's in OverlayNodeFactory?.h).

Anyway, does moving the static into the ::instance() method fixes the build with clang ? See attached patch.

Changed 5 months ago by strk

Changed 5 months ago by hobu

Yes this fixes clang's complaint. Committed to 3.3 branch in r3545.

Changed 5 months ago by strk

Hobu: could you please also commit an entry in the NEWS file about this ? And a forward port to trunk would also be nice. Thank you!

Changed 5 months ago by hobu

confirmed fix and applied in trunk in r3546

Changed 5 months ago by hobu

  • status changed from new to closed
  • resolution set to fixed

note added in 3.3 branche NEWs in r3547

Note: See TracTickets for help on using tickets.