Opened 18 years ago

Last modified 15 years ago

#45 closed defect (fixed)

Rename enum elements INSERT/DELETE

Reported by: mloskot Owned by: strk@…
Priority: major Milestone:
Component: Core Version: main
Severity: Content Keywords: imported, phpbugtracker
Cc:

Description (last modified by mloskot)

I suggest to rename anonymous enums elements e.g. in SweepLineEvent class currently defined as 

enum {
   INSERT = 1,
   DELETE
};

to read as 

enum {
   INSERT_EVENT = 1,
   DELETE_EVENT
};

This change will help to avoid potential problems on Windows where system header <winnt.h> defines DELETE macro. Currently, this change is required to make GEOS compilable using VC++ 8.0 for Windows CE.

Fixed in patch attached

Attachments (1)

geos-INSERT_EVENT-mloskot-20060302.3.patch​ (3.5 KB ) - added by mateusz@… 18 years ago.
Generated with cvs diff -U2

Download all attachments as: .zip

Change History (4)

by mateusz@…, 18 years ago

Attachment: geos-INSERT_EVENT-mloskot-20060302.3.patch​ added

Generated with cvs diff -U2

comment:1 by strk@…, 18 years ago

Resolution: none → fixed

comment:2 by mloskot, 17 years ago

Description: modified (diff)
Milestone: imported → 3.0.0
Priority: 1 → major
Reporter: changed from mateusz@… to mloskot
Severity: Annoyance → Content
Version: 3.0.0 → svn-trunk

comment:3 by (none), 15 years ago

Milestone: 3.0.0

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.