Assertion fails checking validity of polygon

[strk]

See  http://trac.osgeo.org/postgis/ticket/1007 for the dataset.

bool geos::operation::valid::IndexedNestedRingTester::isNonNested(): Assertion `innerRingPt!=null' failed.

[strk]

Note: JTS (rev 398) also fails against the attached testcase:

Case bug449.xml - #1 (4): http://trac.osgeo.org/geos/ticket/449
Test Threw Exception (B isValid, true)     java.lang.NullPointerException

[strk]

The message is correct: a triangle hole has all vertices touching nearby holes. I'll have to dig further in order to tell if that's an invalidity of input (sounds like )

[strk]

The bug449-simp.xml file is an extremely simplified version of the test. It's a polygon with two holes. One of the two holes shares all vertices with another hole, thus triggering the assertion failure. I pretty much belive this case being invalid, and I'm trying to think of a possible other _valid_ case. I dubt I'll find one though..

[strk]

Fixed on the GEOS side with r3392. The changeset includes a proper XML (the one attached here was malformed). JTS still fails.

[strk]

#451 is the backport to 3.2 branch

[strk]

JTS fixed this. It should be checked _how_ and make sure GEOS follows that.

[strk]

Also, should be back-ported to 3.3 branch (trunk became 3.4.0 instead)

[strk]

JTS fix here:  http://jts-topo-suite.svn.sourceforge.net/viewvc/jts-topo-suite?view=revision&revision=399

[strk]

#456 is the backport to 3.3 branch

[strk]

Re-done the JTS way with r3422 (reversion of older commit) and r3423 (new version). This new version has tests included in the JTS official ones.