Opened 15 years ago
Closed 15 years ago
#257 closed defect (fixed)
trunk build with visual studio 2008
Reported by: | sanak | Owned by: | mloskot |
---|---|---|---|
Priority: | major | Milestone: | 3.2.0 |
Component: | Build/Install | Version: | main |
Severity: | Unassigned | Keywords: | |
Cc: |
Description
I had tried to build trunk source with visual studio 2008 at last weekend, and some files seems to be necessary to correct.
The following files are the windows specific files.
- /nmake.opt
- /source/Makefile.vc
- /source/dirlist.mk
- /build/msvc90/geos_lib/geos_lib.vcproj
- /build/msvc90/geos_unit/geos_unit.vcproj
And the following seemed to be necessary to deal.
1) add "#include <cassert>"
- /source/geom/LinearRing.cpp
- /source/index/chain/MonotoneChainBuilder.cpp
2) change "round" to "util::round"
- /source/headers/geos/algorithm/distance/DiscreteHausdorffDistance.h
3) the following header files move to /source/headers/operation/*/*.h
- /source/operation/buffer/BufferInputLineSimplifier.h
- /source/operation/buffer/OffsetCurveVertexList.h
- /source/operation/valid/IndexedNestedRingTester.h
4) couldn't compile "geos::operation::buffer::BufferBuilder::bufferLineSingleSided" at the following line.
curveList.push_back( new NodedSegmentString( lineList[i], NULL ) );
5) /tests/unit/operation/valid/IsValidTest.cpp crushed by null pointer referrence.
isValidOp.getValidationError() return null.
Attachments (1)
Change History (6)
by , 15 years ago
Attachment: | fix-msvc.patch added |
---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Owner: | changed from | to
---|
comment:3 by , 15 years ago
Status: | new → assigned |
---|
comment:4 by , 15 years ago
Fixed in trunk (r2538)
Noticed that unit tests fail:
1>geos::util::UniqueCoordinateArrayFilter?: . 1>---> group: geos::operation::valid::IsValidOp?, test: test<1> 1> problem: assertion failed
comment:5 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Notice for the patch file(fix-msvc.patch)
-created by TortoiseSVN(Japanese).
-didn't deal "3) move header". -didn't deal "4) bufferLineSingleSided"(only commented out with #if 0).
Regards,