Ticket #257 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

trunk build with visual studio 2008

Reported by: sanak Owned by: mloskot
Priority: major Milestone: 3.2.0
Component: Build/Install Version: svn-trunk
Severity: Unassigned Keywords:
Cc:

Description

I had tried to build trunk source with visual studio 2008 at last weekend, and some files seems to be necessary to correct.

The following files are the windows specific files.
- /nmake.opt
- /source/Makefile.vc
- /source/dirlist.mk
- /build/msvc90/geos_lib/geos_lib.vcproj
- /build/msvc90/geos_unit/geos_unit.vcproj

And the following seemed to be necessary to deal.

1) add "#include <cassert>"
- /source/geom/LinearRing.cpp
- /source/index/chain/MonotoneChainBuilder.cpp

2) change "round" to "util::round"
- /source/headers/geos/algorithm/distance/DiscreteHausdorffDistance.h

3) the following header files move to /source/headers/operation/*/*.h
- /source/operation/buffer/BufferInputLineSimplifier.h
- /source/operation/buffer/OffsetCurveVertexList.h
- /source/operation/valid/IndexedNestedRingTester.h

4) couldn't compile "geos::operation::buffer::BufferBuilder::bufferLineSingleSided" at the following line.

curveList.push_back( new NodedSegmentString?( lineList[i], NULL ) );

5) /tests/unit/operation/valid/IsValidTest.cpp crushed by null pointer referrence.

isValidOp.getValidationError() return null.

Attachments

fix-msvc.patch Download (17.5 KB) - added by sanak 3 years ago.

Change History

Changed 3 years ago by sanak

Changed 3 years ago by sanak

Notice for the patch file(fix-msvc.patch)
-created by TortoiseSVN(Japanese).
-didn't deal "3) move header". -didn't deal "4) bufferLineSingleSided"(only commented out with #if 0).

Regards,

Changed 3 years ago by pramsey

  • owner changed from pramsey to mloskot

Changed 3 years ago by mloskot

  • status changed from new to assigned

Changed 3 years ago by mloskot

Fixed in trunk (r2538)

Noticed that unit tests fail:

1>geos::util::UniqueCoordinateArrayFilter?: .
1>---> group: geos::operation::valid::IsValidOp?, test: test<1>
1> problem: assertion failed 

Changed 2 years ago by sanak

  • status changed from assigned to closed
  • resolution set to fixed

Oops, sorry for late reply. Unit tests(IsValidOp?) problem was fixed at #259.

Note: See TracTickets for help on using tickets.