Ticket #242 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

GEOSSetSRID_r missing, GEOSSetSRID duplicated

Reported by: tazle Owned by: mloskot
Priority: major Milestone: 3.2.0
Component: C API Version: 3.1.0
Severity: Unassigned Keywords:
Cc:

Description (last modified by mloskot) (diff)

Currently there is no GEOSSetSRID_r declaration or implementation in the C API. Instead there is another GEOSSetSRID implementation in the thread-safe implementation and two GEOSSetSRID (second one) declarations in the header.

I think there should be GEOSSetSRID_r for consistency even if GEOSSetSRID is thread-safe (it seems like it might be) - certainly all other functions have _r counterparts.

Attachments

geossetsrid-ts-ticket-242.patch Download (2.4 KB) - added by mloskot 4 years ago.
Patch with implementation of missing GEOSSetSRID_r. It's going to be applied to trunk after GEOS 3.1.0 is released.

Change History

Changed 4 years ago by mloskot

  • description modified (diff)
  • milestone 3.1.1 deleted

Changed 4 years ago by mloskot

  • owner changed from pramsey to mloskot
  • status changed from new to assigned

Changed 4 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to 3.2.0

Fixed in trunk (r2300). Please, test and confirm it works, reopen the ticket if it doesn't.

Changed 4 years ago by mloskot

  • status changed from closed to reopened
  • resolution fixed deleted

Unfortunately, this submission touches public API and we are not working on a dedicated branch (yet). So, I've reverted (r2301) and preparing a file-based patch.

Changed 4 years ago by mloskot

Patch with implementation of missing GEOSSetSRID_r. It's going to be applied to trunk after GEOS 3.1.0 is released.

Changed 4 years ago by strk

  • status changed from reopened to closed
  • resolution set to fixed

Committed as revision 2491.

Changed 4 years ago by strk

Ah, I now realize I should write r2491 for good stuff...

Note: See TracTickets for help on using tickets.