Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#242 closed defect (fixed)

GEOSSetSRID_r missing, GEOSSetSRID duplicated

Reported by: tazle Owned by: mloskot
Priority: major Milestone: 3.2.0
Component: C API Version: 3.1.0
Severity: Unassigned Keywords:
Cc:

Description (last modified by mloskot)

Currently there is no GEOSSetSRID_r declaration or implementation in the C API. Instead there is another GEOSSetSRID implementation in the thread-safe implementation and two GEOSSetSRID (second one) declarations in the header.

I think there should be GEOSSetSRID_r for consistency even if GEOSSetSRID is thread-safe (it seems like it might be) - certainly all other functions have _r counterparts.

Attachments (1)

geossetsrid-ts-ticket-242.patch (2.4 KB ) - added by mloskot 15 years ago.
Patch with implementation of missing GEOSSetSRID_r. It's going to be applied to trunk after GEOS 3.1.0 is released.

Download all attachments as: .zip

Change History (7)

comment:1 by mloskot, 15 years ago

Description: modified (diff)
Milestone: 3.1.1

comment:2 by mloskot, 15 years ago

Owner: changed from pramsey to mloskot
Status: newassigned

comment:3 by mloskot, 15 years ago

Milestone: 3.2.0
Resolution: fixed
Status: assignedclosed

Fixed in trunk (r2300). Please, test and confirm it works, reopen the ticket if it doesn't.

comment:4 by mloskot, 15 years ago

Resolution: fixed
Status: closedreopened

Unfortunately, this submission touches public API and we are not working on a dedicated branch (yet). So, I've reverted (r2301) and preparing a file-based patch.

by mloskot, 15 years ago

Patch with implementation of missing GEOSSetSRID_r. It's going to be applied to trunk after GEOS 3.1.0 is released.

comment:5 by strk, 15 years ago

Resolution: fixed
Status: reopenedclosed

Committed as revision 2491.

comment:6 by strk, 15 years ago

Ah, I now realize I should write r2491 for good stuff...

Note: See TracTickets for help on using tickets.