Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#140 closed defect (fixed)

Error in contains

Reported by: trunfio@… Owned by:
Priority: major Milestone:
Component: Core Version: main
Severity: Significant Keywords: imported, phpbugtracker
Cc: mloskot

Description (last modified by mloskot)

In Geometry::contains the optimization for rectangles doesn't work when 

isRectangle()==false and g->isRectangle==true.
Indeed the case: 
if (g->isRectangle()) {
return predicate::RectangleContains::contains((const Polygon&)*g, *this);
}

is wrong and should be eliminated.

Change History (7)

comment:1 by strk@…, 17 years ago 

Can you provide a testcase for the failure ?
An XML test would be best.

comment:2 by mloskot, 16 years ago

Cc: mloskot added
Description: modified (diff)

comment:3 by mloskot, 16 years ago

Milestone: imported

comment:4 by mloskot, 16 years ago

Component: Build scripts → Core
Milestone: → 3.0.0
Priority: 1 → major
Severity: Unassigned → Significant
Version: 3.0.0 → svn-trunk

comment:5 by mloskot, 16 years ago

Owner: strk@… removed
Status: assigned → new

comment:6 by benjubb, 16 years ago

Resolution: → fixed
Status: new → closed

Checked in a fix to trunk.

comment:7 by (none), 15 years ago

Milestone: 3.0.0

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.