Opened 15 years ago

Last modified 12 years ago

#50 new defect

edit feature attributes in featurepanel_form does not work

Reported by: woodbri Owned by:
Priority: major Milestone: 1.8.0
Component: widgets Version:
Keywords: Cc:

Description

Alexandre wrote:

One quick problem I found :

 in ./src/client/widgets/featurepanel/form/Form.xslt, at line 266, replace :
     objGP<xsl:value-of select="$pWidgetName" />
 for
    objGPWidget<xsl:value-of select="$pWidgetName" />

Either if this is enough for this to work or not, please fill a ticket. A patch would be welcomed too.

The above solves the JS error when loading the page mentioned below. But the featurepanel_form does not show in the West panel when I add a feature. Also if you collapse the layertree widget it will not open again.

In response to Stephen Woodbridge original message:

This is not critical and I know you said it was not tested. I step up a test case to try this out and I get an error in ext-all.js and the stack trace does not help me understand the issue.

http://imaptools.com:8080/project/myproj2/index2.php http://imaptools.com:8080/project/myproj2/config2.xml

I set <inwindow>false</inwindow>

http://imaptools.com:8080/project/myproj2/xslt/default2.xslt

And added the following to the xslt template:

        <xsl:for-each select="/geoprisma/widgets/widget[./type = 'featurepanel_form']">
          <xsl:if test="./options/inwindow = 'false'">
          oWestPanel.items.push(
            <xsl:call-template name="featurepanel_form:drawWidget">
              <xsl:with-param name="pWidgetName" select="./name" />
            </xsl:call-template>);
          </xsl:if>
        </xsl:for-each>

And what I end up with is a lot of lines like:

  oWestPanel.items.push(objGPFeaturePanelForm_ONEMILEETJ);
  oWestPanel.items.push(objGPFeaturePanelForm_LAKES);
  ...

where these are all undefined:

  objGPFeaturePanelForm_ONEMILEETJ
  objGPFeaturePanelForm_LAKES
  ...

So I'm probably missing something the outputs those definitions.

I also suspect the I probably want something more like the QuickZoomForm where all of these objects get pushed onto an items[] array and then that is pushed on the panel so there is only one tab with all the featurepanel_form in it and the widget then makes the appropriate one visible when it is used and populated with values.

Change History (6)

comment:1 by adube, 13 years ago

Milestone: 1.0.0

Is this still a valid issue ?

comment:2 by woodbri, 13 years ago

I'm not currently using geoprisma, so I don't know.

comment:3 by adube, 13 years ago

Milestone: 1.0.01.2.0

The FeaturePanel_Form widget won't be part of the 1.0 release, so I'm pushing this one to 1.2.

comment:4 by adube, 13 years ago

Milestone: 1.2.01.4.0

Feature editing isn't in 1.2 objectives, pushed to 1.4.

comment:5 by adube, 12 years ago

Milestone: 1.4.01.6.0

No patch, pushed to 1.6.

comment:6 by adube, 12 years ago

Milestone: 1.6.01.8.0

No patch, pushed to 1.8.

Note: See TracTickets for help on using tickets.