Opened 12 years ago
Closed 12 years ago
#379 closed defect (fixed)
TemplatePopup - Rewrite queries URL
Reported by: | fgagnon | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.2.0 |
Component: | widgets | Version: | trunk |
Keywords: | templatepopup | Cc: |
Description
The widget still requires some adjustements to be reliable.
The WMSGetFeatureInfo control used by TemplatePopup uses all WMS layers of the map, yet only use the first layer's URL. Also, some of these layers are Tilecache which does not support WMSGetFeatureInfo. This widget must construct its URLs more accurately
Attachments (4)
Change History (10)
by , 12 years ago
comment:1 by , 12 years ago
Some major changes to the code were made. Included in this patch :
- The xslt now builds an URL to use for queries on the proxy, and the corresponding layers are specified to the JS.
- 2 new options, serviceName (the service to use with the query) and queryVisible (see Openlayers.Control.WFSGetFeatureInfo)
- A new class definition -> A simple override of WFSGetFeatureInfo on URLs comparison that conflict with proxy alliases
comment:2 by , 12 years ago
Component: | samples → widgets |
---|
comment:3 by , 12 years ago
Here's a small review with fixes to do :
- 'serviceType' : becomes obsolete since we specify the name of the service directly. This type should be automatically set from service name.
- with 'serviceType' removed, the 'serviceName' would sound like you could pick any type of service. The doc should mention 'wms' nor 'wfs' for it. Also, the xslt code currently support 'wms' only, so it should at least be mentioned if no work for 'wfs' is to come.
- a lot of the options are managed by "choose/when/otherwise" manually when it could have been automatically handled by the "getObjectFromNode" template. Please, make the according changes.
- documentation : queryVisible -> add "Defaults to true" first.
- xslt : remove or replace "Resource Title" comment
comment:4 by , 12 years ago
All proposed fixes were applied. However some options are still managed differently and different default options are specified left and right. A clean up might be beneficial before future developpement.
comment:5 by , 12 years ago
Added some validations to confirm that layers used use the specified service (serviceName option)
comment:6 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch applied in r1249. Thanks a lot for your hard work.
Any other fixes/enhancements should come in a new ticket.
Multiple changes included, see below.