Opened 15 years ago

Closed 14 years ago

#11 closed defect (wontfix)

DataStore <params> -> <layer>

Reported by: yvesm Owned by: adube
Priority: major Milestone:
Component: widgets Version: 0.7
Keywords: Cc:

Description

The <params> tag of the DataStore SHOULD be changed to <layer>.
The <layers> tag of <params> in DS SHOULD be changed to <name>.

Widgets that use /params/layers should be fixed accordingly.

Change History (4)

comment:1 by adube, 14 years ago

I don't think that change gives would give any new advantages at all, so it could be forgotten. I propose to close this ticket as a "wontfix".

comment:2 by yvesm, 14 years ago

It's just that in the doc we say "[A datastore is] the equivalent of a layer of a server, i.e. a LAYER of a mapfile (MapServer), or a layer in a configuration file (FeatureServer, TileCache)". I thought it would make it clearer for someone looking at a capabilities document to see a LAYER there corresponds to a <layer> with a <name> in a datastore, but I don't care much really.

comment:3 by adube, 14 years ago

I share the exact same thoughts, but I would avoid using too much xml nodes.

This would be enough IMHO :

<datastore>
  <name>DS_MyDataStore</name>
  <layer>mylayer</layer>
</datastore>

Or even better, since not all DS have 'layer' properties, it could have been an option :

<datastore>
  <name>DS_MyDataStore</name>
  <options>
    <layer>mylayer</layer>
  </options>
</datastore>

The reason why I'd like to keep the XML shorter and sweeter is that it's easier that way to convert that in a database (PGSQLMapContextConfig driver).

But as you say, it doesn't matter at this point, so I wouldn't mind closing this ticket and forget about it.

comment:4 by yvesm, 14 years ago

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.