Current CVS version has TIFFRewriteDirectory bug

[Markus Neteler]

Hi Frank,

the current CVS version refuses to compile on both
Redhat 7.1 and Suse7.2

make[1]: Entering directory `/amd/cage0/ssi/BIO/gdal/apps'
gcc -I/amd/ssi0/ssi/neteler/soft/gdal -I/amd/ssi0/ssi/neteler/soft/gdal/port
-I/amd/ssi0/ssi/neteler/soft/gdal/core -I/amd/ssi0/ssi/neteler/soft/gdal/ogr
-I/amd/ssi0/ssi/neteler/soft/gdal/frmts -c -Wall -fPIC -O2
-I/usr/local/include    -I/usr/local/include  gdalinfo.c -o gdalinfo.o
c++  gdalinfo.o  /amd/ssi0/ssi/neteler/soft/gdal/ogr/ogrsf_frmts/ogrsf_frmts.a 
/amd/ssi0/ssi/neteler/soft/gdal/gdal.a /amd/ssi0/ssi/neteler/soft/gdal/ogr/ogr.a
/amd/ssi0/ssi/neteler/soft/gdal/gdal.a
/amd/ssi0/ssi/neteler/soft/gdal/port/cpl.a  -lgif -ljpeg -ltiff -lpng -lz -lm
-ldl -L/usr/local/lib -lm \
         -o gdalinfo
/amd/ssi0/ssi/neteler/soft/gdal/gdal.a(geotiff.o): In function
`GTiffDataset::~GTiffDataset(void)':
geotiff.o(.text+0x1341): undefined reference to `TIFFRewriteDirectory'
collect2: ld returned 1 exit status
make[1]: *** [gdalinfo] Error 1
make[1]: Leaving directory `/amd/cage0/ssi/BIO/gdal/apps'
make: *** [apps-target] Error 2

Redhat7.1 uses libtiff3.5.
I report here just to store this bug.

Obviously the TIFFVERSION exclusion in gtiff.cpp is not yet complete
to ignore TIFFRewriteDirectory in case not present in libtiff.

Thanks for all your work,

 Markus Neteler

[warmerdam]

Markus,

I changed the code in CVS late last week to read like this:

#if defined(TIFFLIB_VERSION)
#if  TIFFLIB_VERSION > 20010925 && TIFFLIB_VERSION != 20011807
        TIFFRewriteDirectory( hTIFF );
#endif
#endif

I would expect this to not compile in TIFFRewriteDirectory() with libtiff
3.5.5.  What is TIFFLIB_VERSION set to in the tiffvers.h file on your
system?

[warmerdam]

I presume this is fixed since Markus hasn't said anything.