Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6862 closed defect (fixed)

Was removing ">2" intentional?

Reported by: Kurt Schwehr Owned by: Even Rouault
Priority: normal Milestone:
Component: default Version: unspecified
Severity: normal Keywords:
Cc:

Description

r36979

Was this change in ogrcsvdriver.cpp intentional? 

- (strlen(osBaseFilename) > 2
+ (osBaseFilename.size()

Change History (4)

comment:1 by Even Rouault, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 38031:

CSV: fix comparison broken in r36979 (fixes #6862)

comment:2 by Even Rouault, 7 years ago

In 38032:

CSV: fix comparison broken in r36979 (fixes #6862)

in reply to:  description comment:3 by Even Rouault, 7 years ago

Was this change in ogrcsvdriver.cpp intentional?

Absolutely not. How did you notice that ??? Thanks

comment:4 by Kurt Schwehr, 7 years ago

I got a clang-tidy complaint about using .size() rather than !.empty() after you had fixed all of them. Looking at the change in r36979 , it was different than the rest without an explanation in the change description.

Note: See TracTickets for help on using tickets.