SHAPE_DEBUG in gdalgeoloc.cpp does not make sense.

[Kurt Schwehr]

This obviously can't be working for the average user. From gdalgeoloc.cpp:

#ifdef SHAPE_DEBUG
#include "/u/pkg/shapelib/shapefil.h"   // <-- What?

SHPHandle hSHP = NULL;
DBFHandle hDBF = NULL;
#endif

Added in r9950.

Have not looked to see where else SHAPE_DEBUG occurs.

The question is fix or remove the stuff inside SHAPE_DEBUG?

[warmerdam]

I would suggest removal.

[Kurt Schwehr]

I also note that the code within SHAPE_DEBUG is inside of notdef, so it is doubly not used.

I will first remove the SHAPE_DEBUG code. After that, I'll remove the notdef stuff. The notdefs were added > 10 years ago in:

• r9950
• r12420

I think we are at the point where someone motivated could dig back through older versions if they want to look at the prior implementation while doing a new one.

[Kurt Schwehr]

• r35948 Removed SHAPE_DEBUG
• r35949 Removed notdef FindGeoLocPosition() and other dead code