#6496 closed task (invalid)
odd header dependence in ogrgeojsondatasource.cpp
| Reported by: | springmeyer | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | default | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I noticed that ogr/ogrsf_frmts/geojson/ogrgeojsondatasource.cpp depends on gdal_utils.h. It seems like the only header that does withing the frmts directory. If this design is fully intensional, please ignore this ticket. But if this is perhaps just a work in progress, I wonder if it would make sense to have gdal_utils.h inside gcore.h rather than apps/?
Change History (2)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
It does not cause any particular issue. The reason I noticed is that node-gdal's build system (which bundles gdal) was previously removing the app folder to cut down on things unnecessary for libgdal: https://github.com/naturalatlas/node-gdal/blob/master/deps/libgdal.sh#L28. I fixed this in the gdal 2.1.0 upgrade: https://github.com/naturalatlas/node-gdal/pull/166/commits/2102bb860c8317fa08f8a6e2805a5dc8d39a41c7#diff-6c9d474532aed7885191a137bfb74b85L28
Will close now as the design is fully intentional.
Yes it is intentional as it uses GDALVectorTranslate(). The reason for gdal_utils.h being in apps/ is that the implementation code is in the same directory. Does the current location cause any particular issue ?