Missing typemaps in C# binding for Gdal

[ccjklppp]

I'm using the c# binding.all methods that should get as argument Dataset[], actually expects type SWIGTYPE_p_p_GDALDatasetShadow instead. this happens in the following methods:
Gdal.CreatePansharpenedVRT(...)
Gdal.wrapper_GDALBuildVRT_objects(...)
Gdal.wrapper_GDALWarpDestDS(...)
Gdal.wrapper_GDALWarpDestName(...)

moreover, the method Gdal.wrapper_GDALVectorTranslateDestDS(...) expect to get Datasets (src & dst) while it should get Datasource (vector) isn't it?

[Even Rouault]

Tamas, will you be able to work on that for 2.1.0 ?

[ccjklppp]

anyone??

[ccjklppp]

I have made a workaround to the problem:
I've changed the gdalwarp interfaces so it will be like the gdalbuildvrt interfaces -
one method gets the input/output file names and another method gets the input/output dataset objects

All the changes I've made are in the file: swig\include\gdal.i
and this is the changed part:

//************************************************************************
// gdal.Warp()
//************************************************************************

#ifdef SWIGJAVA
%rename (WarpOptions) GDALWarpAppOptions;
#endif
struct GDALWarpAppOptions {
%extend {
    GDALWarpAppOptions(char** options) {
        return GDALWarpAppOptionsNew(options, NULL);
    }

    ~GDALWarpAppOptions() {
        GDALWarpAppOptionsFree( self );
    }
}
};

#ifdef SWIGJAVA
%rename (Warp) wrapper_GDALWarp_objects;
#endif

/* Note: we must use 2 distinct names due to different ownership of the result */

%inline %{
int wrapper_GDALWarp_objects( GDALDatasetShadow* dstDS,
                            int object_list_count, GDALDatasetShadow** poObjects,
                            GDALWarpAppOptions* options,
                            GDALProgressFunc callback=NULL,
                            void* callback_data=NULL)
{
    int usageError; /* ignored */
    bool bFreeOptions = false;
    if( callback )
    {
        if( options == NULL )
        {
            bFreeOptions = true;
            options = GDALWarpAppOptionsNew(NULL, NULL);
        }
        GDALWarpAppOptionsSetProgress(options, callback, callback_data);
    }
    int bRet = (GDALWarp(NULL, dstDS, object_list_count, poObjects, options, &usageError) != NULL);
    if( bFreeOptions )
        GDALWarpAppOptionsFree(options);
    return bRet;
}
%}

#ifdef SWIGJAVA
%rename (Warp) wrapper_GDALWarp_names;
#endif

%newobject wrapper_GDALWarp_names;
%apply (char **options) {char** source_filenames};
%inline %{
GDALDatasetShadow* wrapper_GDALWarp_names( const char* dest,
                                             char ** source_filenames,
                                             GDALWarpAppOptions* options,
                                             GDALProgressFunc callback=NULL,
                                             void* callback_data=NULL)
{
    int usageError; /* ignored */
    bool bFreeOptions = false;
    if( callback )
    {
        if( options == NULL )
        {
            bFreeOptions = true;
            options = GDALWarpAppOptionsNew(NULL, NULL);
        }
        GDALWarpAppOptionsSetProgress(options, callback, callback_data);
    }
	
	int nInputFiles = CSLCount(source_filenames);
	GDALDatasetH* poObjects = (GDALDatasetH*) CPLMalloc(nInputFiles * sizeof(GDALDatasetH));
	for(int i=0;i<nInputFiles;i++)
    {
		poObjects[i] = GDALOpen(source_filenames[i], GA_ReadOnly );
    }
	
    GDALDatasetH hDSRet = GDALWarp(dest, NULL, nInputFiles, poObjects, options, &usageError);
	
	for(int i=0;i<nInputFiles;i++)
    {
		GDALClose(poObjects[i]);
    }
	CPLFree(poObjects);

    if( bFreeOptions )
        GDALWarpAppOptionsFree(options);
    return hDSRet;
}
%}

the full file is attached.
I would appreciate if you put the changes to the trunk version...

[ccjklppp]

swig\include\gdal.i

[Even Rouault]

The proposed gdal.i would break the Python bindings. I guess what is needed is a typemap for (int object_list_count, GDALDatasetShadow poObjects) in swig/include/csharp/typemaps_csharp.i

[Even Rouault]

Removing target milestone as it corresponds to a now closed milestone.

[Even Rouault]

Postponing to later milestone

[Even Rouault]

Ticket retargeted after milestone closed

[Franik]

Is this issue planned for the next release? It would be really helpful. This seems to keep getting postponed even though it has the highest priority. Any info on the current state would be appreciated.

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.