Windows VS warnings for hdf4

[Kurt Schwehr]

These were seen by Joaquim Luis. Very similar looking to clang -Weverything.

This comes out of #6212

v:\gdal\frmts\hdf4\hdf4imagedataset.cpp(2550) : warning C4701: potentially uninitialized local variable 'iWrkNumType' used

but it's probably a false positive. As are ...

v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(449) : warning C4701: potentially uninitialized local variable 'sdInterfaceID' used
v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(436) : warning C4701: potentially uninitialized local variable 'HDFfid' used
v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(446) : warning C4701: potentially uninitialized local variable 'acs' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(2632) : warning C4701: potentially uninitialized local variable 'ndims' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(3270) : warning C4701: potentially uninitialized local variable 'c_info' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(3281) : warning C4701: potentially uninitialized local variable 'chunkDef' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(8618) : warning C4701: potentially uninitialized local variable 'rank' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9568) : warning C4701: potentially uninitialized local variable 'xdum' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9070) : warning C4701: potentially uninitialized local variable 'j' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9569) : warning C4701: potentially uninitialized local variable 'ydum' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9685) : warning C4701: potentially uninitialized local variable 'size' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9847) : warning C4701: potentially uninitialized local variable 'xdum' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9848) : warning C4701: potentially uninitialized local variable 'ydum' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(10113) : warning C4701: potentially uninitialized local variable 'nRetn' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(6501) : warning C4701: potentially uninitialized local variable 'yMtr0' used
v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(6500) : warning C4701: potentially uninitialized local variable 'xMtr0' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(4282) : warning C4701: potentially uninitialized local variable 'nVal' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(5839) : warning C4701: potentially uninitialized local variable 'j' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7267) : warning C4701: potentially uninitialized local variable 'incr' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7301) : warning C4701: potentially uninitialized local variable 'offset' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7271) : warning C4701: potentially uninitialized local variable 'index' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7249) : warning C4701: potentially uninitialized local variable 'bufOffset' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(8428) : warning C4701: potentially uninitialized local variable 'incr' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(8414) : warning C4701: potentially uninitialized local variable 'index' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(9199) : warning C4701: potentially uninitialized local variable 'j' used
v:\gdal\frmts\hdf4\hdf-eos\swapi.c(2451) : warning C4701: potentially uninitialized local variable 'vdataID' used
xcopy /D /Y *.obj ..\..\o
V:EHapi.obj
V:gctp_wrap.obj
V:GDapi.obj
V:SWapi.obj
4 File(s) copied

V:\gdal\frmts>cd hdf5 && nmake /nologo /f makefile.vc && cd .. || exit 1
cl /Zi /Fd..\..\gdal_w64.pdb /nologo /MD /EHsc /FC /D_CRT_SECURE_NO_DEPRECATE /D_CRT_NONSTDC_NO_DEPRECATE /DDEBUG /W4 /wd4127 /wd4251 /wd4275 /wd4786 /wd4100 /wd4245 /wd4206 /wd4018 /wd4389 /DHAVE_SSE_AT_COMPILE_TIME -I..\..\port -I..\..\ogr -I..\..\gcore -I..\..\alg -I..\..\ogr\ogrsf_frmts -I..\..\gnm -I..\..\gnm\gnm_frmts -I..\..\apps -IC:\programs\compa_libs\hdf5-1.8.12\compileds\VC12_64\include -DWIN32 -D_HDF5USEDLL_ -DOGR_ENABLED -DGDAL_COMPILATION /c hdf5dataset.cpp hdf5imagedataset.cpp bagdataset.cpp gh5_convenience.cpp iso19115_srs.cpp
hdf5dataset.cpp
c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition
command-line arguments : see previous definition of '_HDF5USEDLL_'
v:\gdal\frmts\hdf5\hdf5dataset.cpp(1197) : warning C4244: '*=' : conversion from 'hsize_t' to 'unsigned int', possible loss of data
hdf5imagedataset.cpp
c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition
command-line arguments : see previous definition of '_HDF5USEDLL_'
v:\gdal\frmts\hdf5\hdf5imagedataset.cpp(388) : warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data
bagdataset.cpp
c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition
command-line arguments : see previous definition of '_HDF5USEDLL_'
v:\gdal\frmts\hdf5\bagdataset.cpp(314) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
v:\gdal\frmts\hdf5\bagdataset.cpp(358) : warning C4244: 'initializing' : conversion from 'hsize_t' to 'int', possible loss of data
gh5_convenience.cpp
c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition
command-line arguments : see previous definition of '_HDF5USEDLL_'
v:\gdal\frmts\hdf5\gh5_convenience.cpp(62) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
iso19115_srs.cpp

[Even Rouault]

I think I've got rid of them lately