Opened 9 years ago

Closed 5 years ago

#6111 closed defect (wontfix)

deegree vrs typo deegree vrs degree

Reported by: Kurt Schwehr Owned by: warmerdam
Priority: normal Milestone: closed_because_of_github_migration
Component: default Version: unspecified
Severity: normal Keywords:
Cc:

Description

Which "deegree"s are for http://www.deegree.org/ and which are typos? Some are clearly correct, which others are probably wrong.

find . -name "*.[ch]*" | xargs grep -i deegree
[snip]
./ogr/ogrsf_frmts/gml/ogrgmldatasource.cpp:            if (!IsGML3DeegreeOutput())
./ogr/ogrsf_frmts/gml/ogrgmldatasource.cpp:        else if (IsGML3DeegreeOutput())
./ogr/ogrsf_frmts/gml/ogrgmldatasource.cpp:        if (IsGML3DeegreeOutput())
./ogr/ogrsf_frmts/gml/ogr_gml.h:    int                 bIsOutputGML3Deegree; /* if TRUE, then bIsOutputGML3 is also TRUE */
./ogr/ogrsf_frmts/gml/ogr_gml.h:    int                 IsGML3DeegreeOutput() const { return bIsOutputGML3Deegree; }
./ogr/ogrsf_frmts/gml/ogrgmldriver.cpp:"    <Value>GML3Deegree</Value>"
./ogr/ogrct.cpp:    /* we can also avoid transforming from deegrees <--> radians. */
./ogr/gml2ogrgeometry.cpp:                        bool bSRSUnitIsDeegree = false;  // TODO: Is deegree a mispelling of degree?
./ogr/gml2ogrgeometry.cpp:                                    bSRSUnitIsDeegree = fabs(oSRS.GetAngularUnits(NULL) - CPLAtof(SRS_UA_DEGREE_CONV)) < 1e-8;
./ogr/gml2ogrgeometry.cpp:                        if( bSRSUnitIsDeegree && pszUnits != NULL &&
./ogr/gml2ogrgeometry.cpp:        bool bSRSUnitIsDeegree = false;
./ogr/gml2ogrgeometry.cpp:                    bSRSUnitIsDeegree = fabs(oSRS.GetAngularUnits(NULL) - CPLAtof(SRS_UA_DEGREE_CONV)) < 1e-8;
./ogr/gml2ogrgeometry.cpp:        if( bSRSUnitIsDeegree && pszUnits != NULL &&
./ogr/gml2ogrgeometry.cpp:        bool bSRSUnitIsDeegree = false;
./ogr/gml2ogrgeometry.cpp:                    bSRSUnitIsDeegree = fabs(oSRS.GetAngularUnits(NULL) - CPLAtof(SRS_UA_DEGREE_CONV)) < 1e-8;
./ogr/gml2ogrgeometry.cpp:        if( bSRSUnitIsDeegree && pszUnits != NULL &&
./frmts/pcidsk/sdk/segment/cpcidskgeoref.cpp:        units_code = "DEEGREE";

I am pretty sure that anything that refers to units should be degree and no deegree.

Change History (3)

comment:1 by Even Rouault, 9 years ago

ogr/ogrct.cpp ogr/gml2ogrgeometry.cpp r30355 "Replace deegree by degree when it is about the unit (#6111)"

In the GML driver it is about the Deegree software, so fine

In PCIDSK, it's probably a typo as there are occurences of the DEGREE string without the typo. However as it is in the writing part of the driver, it could potentially impact interoperability with PCI software (although I'd say at 90% it's a bug). I have no way to check myself.

comment:2 by Kurt Schwehr, 9 years ago

I sent PCI Geomatica a message through their homepage asking about

source:trunk/gdal/frmts/pcidsk/sdk/segment/cpcidskgeoref.cpp#L261

comment:3 by Even Rouault, 5 years ago

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: newclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.