Use of uninitialized memory in OGRLayer::Update()

[Even Rouault]

There are Valgrind warnings at the line :

if (mapMethod) z->SetFieldsFrom(y, mapMethod);

due to mapMethod not being initialized since set_result_schema() is called in non-combined mode

[Even Rouault]

trunk r28161 "OGR layer algebra: properly initialize field maps to avoid Valgrind warnings in OGRLayer::Update() (#5778)"

I'm not sure if the line z->SetFieldsFrom?(y, mapMethod); should be removed, or if set_result_schema() should be called with combined = 1. Ari, any opinion ?

[Ari Jolma]

Seems to me that the description of the method is which we should read. By default the result gets attributes only from the input layer and not from the method layer. Thus combined = 0. However, by the 1. comment (whose english may be broken), if the user sets the schema, then the result features may get attribute values from method features, thus the SetFieldsFrom call is needed.

[Even Rouault]

Thanks Ari

trunk r28168 "Remove unneeded FIXME" branches/1.11 r28169 "OGR layer algebra: properly initialize field maps to avoid Valgrind warnings in Oyer::Update() (#5778)"