Opened 10 years ago

Closed 10 years ago

#5457 closed enhancement (fixed)

SXF: faulty destruction of the mutex

Reported by: akhliustov Owned by: bishop
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: OGR, SXF
Cc:

Description

SXF datasources use shared mutex which is destroyed here: http://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/sxf/ogrsxfdatasource.cpp#L114. It is a wrong place for destruction, because the mutex can be still in use by another datasource. A better place is in the destructor of the driver.

Change History (4)

comment:1 by Even Rouault, 10 years ago

Owner: changed from warmerdam to bishop

comment:2 by bishop, 10 years ago

Resolution: wontfix
Status: newclosed

The main aim of the mutex is prevent to simultaneously access the same file from different layers. The one SXF file can have several layes, so I set SXF file handler at layer constructor. And I need to prevent the seek and read from different layers simultaneously. But each datasource have diffent file handlers (different SXF files), so there is no need in such global mutex in driver.

comment:3 by akhliustov, 10 years ago

Resolution: wontfix
Status: closedreopened

Well, if there should be one mutex per datasource instance, then it should be datasource member variable, not static.

comment:4 by bishop, 10 years ago

Resolution: fixed
Status: reopenedclosed
Type: defectenhancement

Fixed in r27285

Note: See TracTickets for help on using tickets.