#5204 closed defect (fixed)
Wrong version macros for libPNG in frmts/pngdataset.cpp
| Reported by: | bartoli | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.11.0 |
| Component: | GDAL_Raster | Version: | 1.10.0 |
| Severity: | minor | Keywords: | png |
| Cc: |
Description
In frmts/pngdataset.cpp, LIBPNG_VER_MINOR and LIBPNG_VER_MAJOR are being watched to perform code secific to a version of libPNG. But at least in libpng 1.6, 1.5, and even in the 1.2 shipped with gdal, those macros are actually named PNG_LIBPNG_VER_MAJOR and PNG_LIBPNG_VER_MINOR. This causes some additional info to not be displayed in the following error messsage, because the code thinks this libpng doesn't have the function png_access_version_number()
Change History (3)
comment:1 by , 11 years ago
| Component: | default → GDAL_Raster |
|---|---|
| Keywords: | png added |
| Milestone: | → 2.0 |
| Resolution: | → fixed |
| Status: | new → closed |
comment:2 by , 11 years ago
I just saw that this was not included in 1.10.1. Could it be integrated in 1.10.2 instead of waiting for 2.0, since it won't break any backward compatibility?
comment:3 by , 10 years ago
| Milestone: | 2.0 → 1.11.0 |
|---|
Note:
See TracTickets
for help on using tickets.
Fixed in trunk (r26338)