Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#5182 closed defect (fixed)

[PATCH] OGR dxf/dwg driver defect fix-up

Reported by: ermite Owned by: warmerdam
Priority: normal Milestone: 1.11.0
Component: OGR_SF Version: svn-trunk
Severity: major Keywords: dxf, dwg
Cc:

Description

In the attached code I fixed an error when processing clockwise circle arc and hatch from dxf and dwg.

The current dxf/dwg driver translates the last part in the sample data from a clockwise big circle arc into a counterclockwise circle arc. My code does it right.

Please review.

Attachments (3)

Curvelines.dxf (42.2 KB) - added by ermite 4 years ago.
Sample dxf file
Curvelines.dwg (28.9 KB) - added by ermite 4 years ago.
Sample dwg file
ogrdxfdwg.patch (5.1 KB) - added by ermite 4 years ago.
ogr dxf/dwg patch for incorrect translation

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by ermite

Attachment: Curvelines.dxf added

Sample dxf file

Changed 4 years ago by ermite

Attachment: Curvelines.dwg added

Sample dwg file

Changed 4 years ago by ermite

Attachment: ogrdxfdwg.patch added

ogr dxf/dwg patch for incorrect translation

comment:1 Changed 4 years ago by ermite

Summary: OGR dxf/dwg driver defect fix-up[PATCH] OGR dxf/dwg driver defect fix-up
Version: unspecifiedsvn-trunk

comment:2 Changed 3 years ago by Even Rouault

I've applied part of your patch in r26669 "DXF: fix an error when processing clockwise circle arc (patch by ermite, #5182)"

I couldn't find examples of HATCH object with circular or elliptic arcs. Do you have some ?

comment:3 Changed 3 years ago by Even Rouault

Resolution: fixed
Status: newclosed

trunk r26672 "DXF and DWG: fix linear approximation of circular and elliptic arc in HATCH boundaries (patch by ermite, #5182)"

comment:4 Changed 3 years ago by Even Rouault

trunk r26673 "DXF: completementary fix for arc in HATCH objects (#5182)"

comment:5 Changed 3 years ago by Even Rouault

Milestone: 2.01.11.0
Note: See TracTickets for help on using tickets.