Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4863 closed defect (duplicate)

Null pointer dereference in OGRCreateFromShapeBin

Reported by: damiandixon Owned by: warmerdam
Priority: normal Milestone:
Component: OGR_SF Version: 1.9.1
Severity: normal Keywords: filegdb
Cc:

Description

Line 1289 does not have a catch all else to detect non-supported geometry.

This means that there is a potential to dereference a null pointer at line 1297.

This has happened to me with the sample ESRI FileGDB Shapes.gdb.

Change History (4)

comment:1 by Even Rouault, 12 years ago

Component: defaultOGR_SF
Keywords: filegdb added
Resolution: duplicate
Status: newclosed

Since GDAL 1.9.1 the code around line 1297 is the following :

        if (*ppoGeom != NULL)
            (*ppoGeom)->setCoordinateDimension( bHasZ ? 3 : 2 );

So I don't see where the null pointer dereference can occur. And I've tested with Shapes.gdb from the FileGDB SDK and didn't got crashes.

So I think it is a duplicate of #4441 that was fixed in r23752

Please re-open if I've missed something

comment:2 by damiandixon, 12 years ago

I'll double check the version we are using. It could be that we are using 1.9.0. If it is sorry for the duplicate report.

in reply to:  2 comment:3 by damiandixon, 12 years ago

Replying to damiandixon:

I'll double check the version we are using. It could be that we are using 1.9.0. If it is sorry for the duplicate report.

I can confirm I'm currently using 1.9.0. Sorry for the miss-report.

comment:4 by Even Rouault, 12 years ago

Time to upgrade to 1.9.2 ;-)

Note: See TracTickets for help on using tickets.