Opened 12 years ago

Closed 12 years ago

#4774 closed defect (fixed)

Repeated code in VRTSourcedRasterBand class

Reported by: jorgearevalo Owned by: jorgearevalo
Priority: low Milestone: 1.10.0
Component: default Version: svn-trunk
Severity: trivial Keywords: vrt
Cc:

Description

In vrtsourcedrasterband.cpp, There are some repeated (not necessary) lines of code. The same checking is done before, without changes. Attached, a patch file that gets rid of the redundant code.

Attachments (1)

vrtsourcedrasterband.diff​ (1021 bytes ) - added by jorgearevalo 12 years ago.
Diff file, to patch the current trunk version of vrtsourcedrasterband.cpp

Download all attachments as: .zip

Change History (4)

by jorgearevalo, 12 years ago

Attachment: vrtsourcedrasterband.diff​ added

Diff file, to patch the current trunk version of vrtsourcedrasterband.cpp

comment:1 by Even Rouault, 12 years ago

Looks reasonable. As you're a committer, would you check that it doesn't cause regressions when running the autotest suite and commit it, if it is OK ?

comment:2 by jorgearevalo, 12 years ago

Owner: changed from warmerdam to jorgearevalo
Status: new → assigned

Yes, of course. I'll commmit the change.

comment:3 by jorgearevalo, 12 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in r24816

Note: See TracTickets for help on using tickets.