Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3960 closed defect (fixed)

[windows] fix cpl_port.h of visual c++ for use with MinGW

Reported by: jef Owned by: warmerdam
Priority: normal Milestone: 1.8.1
Component: ConfigBuild Version: unspecified
Severity: normal Keywords:
Cc:

Description

Trying to use GDAL built with Visual C++ leads to problems when using the libraries with MinGW (as done for GRASS in OSGeo4W). The attached patch should fix it.

Attachments (1)

cpl_config.h.vc.diff (754 bytes) - added by jef 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by jef

comment:1 follow-up: Changed 6 years ago by warmerdam

  • Component changed from default to ConfigBuild
  • Milestone set to 1.8.1
  • Resolution set to fixed
  • Status changed from new to closed

Change applied in trunk (r21708) and 1.8 branch (r21709).

I am surprised to find cpl_config.h.vc is used for mingw. In theory it might make sense to use a distinct config file for mingw. However, the changes are harmless so I've applied them.

comment:2 in reply to: ↑ 1 Changed 6 years ago by jef

Replying to warmerdam:

Change applied in trunk (r21708) and 1.8 branch (r21709).

I am surprised to find cpl_config.h.vc is used for mingw. In theory it might make sense to use a distinct config file for mingw. However, the changes are harmless so I've applied them.

GRASS in OSGeo4W (and I think also WinGRASS) is build against the GDAL in OSGeo4W. And apparently the version derived from cpl_config.h.vc is the only one shipped with OSGeo4W. Beware: two unverified assumptions here - but the patch applies cleanly to the OSGeo4W version too.

See also:

  1. (osgeo4w-dev) GDAL 1.8 - Switch Thrown
  2. GRASS #1271
Note: See TracTickets for help on using tickets.