Opened 14 years ago

Last modified 14 years ago

#3704 closed defect

Logical OR where AND expected in OGRStyleMgr::GetPart — at Version 1

Reported by: Mateusz Łoskot Owned by: warmerdam
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: style
Cc:

Description (last modified by Mateusz Łoskot)

In file [source;trunk/gdal/ogr/ogrfeaturestyle.cpp@19068#L673 ogrfeaturestyle.cpp], line 673, there is condition that looks suspicious: 

if ( pszString || strlen(pszString) > 0 )

I think the OR should read AND. Current version may lead to strlen(0) which is invalid.

Change History (1)

comment:1 by Mateusz Łoskot, 14 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.