Opened 14 years ago

Closed 13 years ago

#3571 closed defect (fixed)

Mapinfo driver does not follow OGR Feature Style Spec

Reported by: winkey Owned by: warmerdam
Priority: normal Milestone: 1.8.0
Component: OGR_SF Version: unspecified
Severity: normal Keywords:
Cc: Daniel Morissette

Description

with all the id: parameters the separator between 2 id's should be a "," the mapinfo driver uses a ".".

I used "," in the libkml driver, and the dgn driver does not use a separator that I can see.

In mapserver they use a "." http://svn.osgeo.org/mapserver/trunk/mapserver/mapogr.cpp msOGRGetSymbolId()

The easy fix would be to change the spec, the problem is however that "." is a common char in file names and urls.

Change History (7)

comment:1 by Daniel Morissette, 14 years ago

Cc: Daniel Morissette added

This is a known issue that has been bugging me for a while. It was introduced by Stephane in the initial implementation of the style classes for some reason that's unknown to me (possibly to simplify parsing), and I found out about it only later (i.e. too late).

I think we should try to find a way to fix this and come back to the expected "," everywhere. An application such as MapServer could easily be fixed using conditional code that checks for either "." or "," depending on GDAL/OGR version.

Unfortunately, I am not sure how many other apps make use of the style stuff and have this "." delimiter hardcoded in them and would need to have the same conditional code added.

What do you think Frank?

comment:2 by warmerdam, 14 years ago

I don't think there are many applications using the style stuff, and that we should fix it to the spec, with #ifdef's in mapserver.

comment:3 by winkey, 14 years ago

mitab driver fixed and changes documented in the drivers docs in GDALS trunk.

comment:4 by Even Rouault, 14 years ago

Commited by winkey in r19724. Apparently the change has not yet made its way to MITAB upstream (could not find the related bug in mitab CVS)

comment:6 by Daniel Morissette, 14 years ago

What is your plan to address the possible backwards compatibility issue for apps that support style strings? We need to find out which apps may be affected, maybe through a post on the gdal list, and/or at a minimjum a prominent note about this should be included in the release notes... we should not just wait for GDAL/OGR-based apps to break to tell them "Oh, BTW we changed the delimiter!"

I could have made the change in the source a long time ago, I was just not ready to do it without a clear plan to address the impact on GDAL/OGR-based apps.

comment:7 by Even Rouault, 13 years ago

Milestone: 1.8.0
Resolution: fixed
Status: newclosed

Was released in 1.8.0 with a prominant note in the "Backward compatibility issues" section

Note: See TracTickets for help on using tickets.