Ingres : missing parenthesis in logical test ?

[Even Rouault]

In ogringrestablelayer.cpp, line 547, there's the following code :

        if( EQUAL(osIngresGeomType,"LSEG") 
            || EQUAL(osIngresGeomType,"ILSEG") 
            && poLS->getNumPoints() != 2 )

gcc emits the following warning :

ogringrestablelayer.cpp: In member function ‘OGRErr OGRIngresTableLayer::PrepareOldStyleGeometry(OGRGeometry*, CPLString&)’:
ogringrestablelayer.cpp:549: warning : suggest parentheses around ‘&&’ within ‘||’

But instead, I would think that the parenthesis should be put like this :

        if( (EQUAL(osIngresGeomType,"LSEG") 
            || EQUAL(osIngresGeomType,"ILSEG")) 
            && poLS->getNumPoints() != 2 )

So the current test would be wrong as && has a greater precedence than

[warmerdam]

I agree, fixed in trunk (r18519).

The fix could be backported, but I do not anticipate it being particularly important to do so.