Ticket #2941 (closed defect: fixed)

Opened 4 years ago

Last modified 3 weeks ago

HDF5 driver easily confused about datatypes

Reported by: warmerdam Owned by: warmerdam
Priority: normal Milestone:
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: HDF5
Cc:

Description 

gdalinfo -checksum  HDF5:"groups.h5"://MyGroup/dset1

produces valgrind errors indicating memory corruption. It appears to be due to 32bit integer data being misclassified as 16bit.

A similar problem occurs on 64bit platforms with u64be.h5 being misclassified as 32bit integer.

I presume this problem has existed as long as the hdf5 driver.

Attachments

groups.h5 Download (9.6 KB) - added by warmerdam 4 years ago.
first error demonstrating data.
u64be.h5 Download (2.2 KB) - added by warmerdam 4 years ago.
64bit data demonstrating problem.

Change History

Changed 4 years ago by warmerdam

first error demonstrating data.

Changed 4 years ago by warmerdam

64bit data demonstrating problem.

Changed 4 years ago by warmerdam

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 1.5.5

I have patched this in trunk (r16746), 1.6 (r16747) and 1.5 (r16748). The changes properly treat INT and UINT as 32bit, and decide based on sizeof(long) whether LONG is 32bit (usable) or 64bit (unusable for now). The container dataset object was also changed to not list subdatasets that are of unsupported types (though a debug message is issued).

Ideally at some point we would change the driver to convert unsupported datatypes to supported datatypes.

Changed 4 years ago by rouault

In r16751, I changed the expected checksum due to that fix.

Changed 3 weeks ago by rouault

  • milestone 1.5.5 deleted

Milestone 1.5.5 deleted

Note: See TracTickets for help on using tickets.