Ticket #1996 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

pdsdataset and isis2dataset updates

Reported by: thare Owned by: warmerdam
Priority: normal Milestone: 1.5.0
Component: GDAL_Raster Version: 1.4.2
Severity: normal Keywords: PDS, ISIS2, ISIS3
Cc: warmerdam@…

Description

I have uploaded two upgraded files for pdsdataset.cpp and isis2dataset.cpp. There are changes to the projection section but also many other changes sprinkled through out. Also for the pdsdataset I had to add another routine to check for the cellsize unit

const char *GetKeywordUnit?( const char *pszPath,

int iSubscript, const char *pszDefault = "");

These two .cpp files will need to placed into the new format directory "pds" and change accordingly for the new path. THe old path was "raw". I think there were updates to the NASAKeywordHandler files.

Attachments

isis2dataset.cpp Download (29.0 KB) - added by thare 6 years ago.
ISIS2 enhancements (bug fixes)
isis2dataset_pdsdataset.zip Download (17.1 KB) - added by thare 6 years ago.
ISIS2 and PDS enhancements (bug fixes)
isis2dataset.cpp.patch Download (15.1 KB) - added by mloskot 6 years ago.
Generated regular patch with changes to isis2dataset.cpp file
pdsdataset.cpp.patch Download (32.1 KB) - added by mloskot 6 years ago.
Generated regular patch with changes to pdsdataset.cpp file

Change History

Changed 6 years ago by thare

ISIS2 enhancements (bug fixes)

Changed 6 years ago by thare

ISIS2 and PDS enhancements (bug fixes)

Changed 6 years ago by mloskot

Generated regular patch with changes to isis2dataset.cpp file

Changed 6 years ago by mloskot

Generated regular patch with changes to pdsdataset.cpp file

Changed 6 years ago by warmerdam

  • status changed from new to closed
  • resolution set to fixed

Patches adjusted slightly and applied in r12801, and r12804 with r12802 restoring PAM support I accidentally lost with r12801 (all in trunk).

While doing this I also took care to remove printf's (in favor of CPLDebug() calls), be careful not to pass CPLString directly to printf() style calls (pass .c_str() instead), and avoid hard exit in isis2dataset.cpp (use CPLError, return NULL).

Closing, and thanks!

Note: See TracTickets for help on using tickets.