Opened 16 years ago

Closed 16 years ago

#1989 closed defect (fixed)

OGR AVC driver is slow to detect non matching files

Reported by: Even Rouault Owned by: Daniel Morissette
Priority: high Milestone: 1.6.0
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: ogr avc
Cc: warmerdam, Mateusz Łoskot, Even Rouault

Description

When OGR tries to open a big file (let's a 50 MB GPX file), the OGR AVC driver spends quite a lot of time (in AVCE00ReadOpenE00, called by OGRAVCE00DataSource::Open()) to parse it before realizing that it isn't concerned by the file.

According to Daniel Morissette, it should be possible to detect that it's a E00 file form the first few bytes in the file.

Change History (7)

comment:1 by Even Rouault, 16 years ago

Component: defaultOGR_SF

comment:2 by warmerdam, 16 years ago

Cc: Mateusz Łoskot added
Milestone: 1.5.0

This problem has also been found to be at the root of #1943. Setting milestone to 1.5.0.

comment:3 by Daniel Morissette, 16 years ago

Frank, what would you think of moving the call RegisterOGRAVCBin() closer to the end of the list for 1.5.0 and then move this to the 1.6.0 milestone?

comment:4 by warmerdam, 16 years ago

Milestone: 1.5.01.5.1

Done (r13324).

comment:5 by Even Rouault, 16 years ago

Cc: Even Rouault added
Milestone: 1.5.21.6.0
Priority: normalhigh

Boosting priority.

See #2395 for a test case that made it necessary for the GPX and KML drivers to be fixed.

comment:6 by Daniel Morissette, 16 years ago

Fixed in r15081.

AVCE00ReadOpenE00() has been modified to look for "EXP " at the beginning of the file. If the file doesn't start with "EXP " then it is rejected right away.

comment:7 by Daniel Morissette, 16 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.