Ticket #1989 (closed defect: fixed)

Opened 10 months ago

Last modified 1 month ago

OGR AVC driver is slow to detect non matching files

Reported by: rouault Assigned to: dmorissette
Priority: high Milestone: 1.6.0
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: ogr avc
Cc: warmerdam, mloskot, rouault

Description

When OGR tries to open a big file (let's a 50 MB GPX file), the OGR AVC driver spends quite a lot of time (in AVCE00ReadOpenE00, called by OGRAVCE00DataSource::Open()) to parse it before realizing that it isn't concerned by the file.

According to Daniel Morissette, it should be possible to detect that it's a E00 file form the first few bytes in the file.

Change History

11/13/07 14:22:15 changed by rouault

  • component changed from default to OGR_SF.

11/16/07 10:42:41 changed by warmerdam

  • cc changed from warmerdam to warmerdam, mloskot.
  • milestone set to 1.5.0.

This problem has also been found to be at the root of #1943. Setting milestone to 1.5.0.

12/11/07 10:15:59 changed by dmorissette

Frank, what would you think of moving the call RegisterOGRAVCBin() closer to the end of the list for 1.5.0 and then move this to the 1.6.0 milestone?

12/11/07 11:42:43 changed by warmerdam

  • milestone changed from 1.5.0 to 1.5.1.

Done (r13324).

05/29/08 14:56:16 changed by rouault

  • priority changed from normal to high.
  • cc changed from warmerdam, mloskot to warmerdam, mloskot, rouault.
  • milestone changed from 1.5.2 to 1.6.0.

Boosting priority.

See #2395 for a test case that made it necessary for the GPX and KML drivers to be fixed.

07/30/08 15:26:43 changed by dmorissette

Fixed in r15081.

AVCE00ReadOpenE00() has been modified to look for "EXP " at the beginning of the file. If the file doesn't start with "EXP " then it is rejected right away.

07/30/08 15:26:46 changed by dmorissette

  • status changed from new to closed.
  • resolution set to fixed.