Opened 16 years ago
Closed 16 years ago
#1876 closed defect (fixed)
jasper includes dir hardwired, and inconsistently used
Reported by: | kyngchaos | Owned by: | Mateusz Łoskot |
---|---|---|---|
Priority: | normal | Milestone: | 1.5.0 |
Component: | ConfigBuild | Version: | 1.4.4 |
Severity: | minor | Keywords: | jasper |
Cc: | warmerdam, dron |
Description
Gdalmake.opt.in has JASPER_INCLUDE, which is hardwired to ../libjasper/include. It should be the configured path.
BUT, it doesn't even matter. Configure puts the Jasper include path directly in EXTRA_INCLUDES (CPP_FLAGS), so it does find the configured jasper includes.
So, for tidyness and consistency, either:
- drop JASPER_INCLUDE from gdalmake.opt and the frmts/jpeg2000/gnumakefile, or
- use JASPER_INCLUDE as it was intended and make configure insert the Jasper include path into it in gdalmake.opt, instead of into the general CPP_FLAGS.
Change History (3)
comment:1 by , 16 years ago
Cc: | added |
---|---|
Milestone: | 1.4.3 → 1.5.0 |
Owner: | changed from | to
comment:2 by , 16 years ago
Keywords: | jasper added |
---|---|
Status: | new → assigned |
Version: | 1.4.2 → 1.4.4 |
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Cleaned in trunk (r13131). This change is not going to the branches/1.4
Note:
See TracTickets
for help on using tickets.
Mateusz,
Please clean up as appropriate, but if it isn't seriously breaking things, just address in trunk, not 1.4 branch.