Ticket #1876 (closed defect: fixed)

Opened 9 months ago

Last modified 7 months ago

jasper includes dir hardwired, and inconsistently used

Reported by: kyngchaos Assigned to: mloskot
Priority: normal Milestone: 1.5.0
Component: ConfigBuild Version: 1.4.4
Severity: minor Keywords: jasper
Cc: warmerdam, dron

Description

Gdalmake.opt.in has JASPER_INCLUDE, which is hardwired to ../libjasper/include. It should be the configured path.

BUT, it doesn't even matter. Configure puts the Jasper include path directly in EXTRA_INCLUDES (CPP_FLAGS), so it does find the configured jasper includes.

So, for tidyness and consistency, either:

- drop JASPER_INCLUDE from gdalmake.opt and the frmts/jpeg2000/gnumakefile, or

- use JASPER_INCLUDE as it was intended and make configure insert the Jasper include path into it in gdalmake.opt, instead of into the general CPP_FLAGS.

Change History

09/30/07 00:57:21 changed by warmerdam

  • owner changed from warmerdam to mloskot.
  • cc set to warmerdam, dron.
  • milestone changed from 1.4.3 to 1.5.0.

Mateusz,

Please clean up as appropriate, but if it isn't seriously breaking things, just address in trunk, not 1.4 branch.

11/28/07 11:05:48 changed by mloskot

  • keywords set to jasper.
  • status changed from new to assigned.
  • version changed from 1.4.2 to 1.4.4.

11/28/07 12:38:25 changed by mloskot

  • status changed from assigned to closed.
  • resolution set to fixed.

Cleaned in trunk (r13131). This change is not going to the branches/1.4