Ticket #1831 (closed defect: fixed)

Opened 10 months ago

Last modified 7 months ago

KML driver review and cleanup

Reported by: mloskot Assigned to: mloskot
Priority: normal Milestone: 1.5.0
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: kml
Cc:

Description (Last modified by mloskot)

This ticket brings patch fixing some issues with variables scope. Provided by Christopher Schmidt and forwarded by D|dge to my e-mail.

I've expanded this ticket to with review & cleanup tasks.

Attachments

kml_variable_fixes.diff (6.1 kB) - added by mloskot on 09/14/07 03:26:17.
Patch for the KML driver

Change History

09/14/07 03:26:17 changed by mloskot

  • attachment kml_variable_fixes.diff added.

Patch for the KML driver

09/14/07 03:58:53 changed by mloskot

  • status changed from new to assigned.
  • owner changed from warmerdam to mloskot.

09/14/07 04:00:19 changed by mloskot

Partially applied (r12152). Work in progress, together with review and refactoring but first we need some test cases to control ourselfs :-)

11/19/07 14:52:54 changed by mloskot

  • description changed.
  • summary changed from Patch fixing variables scope in the KML driver to KML driver review and cleanup.

11/19/07 15:03:42 changed by mloskot

I committed a bunch of cleanup changes (r12864)

11/19/07 15:13:00 changed by mloskot

Improved CPLString usage (r12865)

11/19/07 17:52:42 changed by mloskot

More cleanup and refactoring: r12866, r12868, r12869, r12870

11/19/07 19:51:42 changed by mloskot

Yet another package of improvements: r12871, r12872, r12873

11/19/07 20:52:24 changed by mloskot

Next part of review changes: r12874, r12875

11/19/07 21:18:11 changed by mloskot

Fixed small bug in KML::eliminateEmpty() submitted in r12875 (r12877).

11/20/07 17:45:35 changed by mloskot

Print parsed KML tree only under debug run requested by setting environment CPL_DEBUG=ON (r12901)

11/28/07 01:19:14 changed by mloskot

  • priority changed from high to normal.

Putting it on the end of the 1.5.0 queue

12/18/07 14:16:28 changed by hobu

  • status changed from assigned to closed.
  • resolution set to fixed.

Done for 1.5. We'll open a new bug for 1.6-related KML work.