Opened 17 years ago

Closed 16 years ago

#1831 closed defect (fixed)

KML driver review and cleanup

Reported by: Mateusz Łoskot Owned by: Mateusz Łoskot
Priority: normal Milestone: 1.5.0
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: kml
Cc:

Description (last modified by Mateusz Łoskot)

This ticket brings patch fixing some issues with variables scope. Provided by Christopher Schmidt and forwarded by D|dge to my e-mail.

I've expanded this ticket to with review & cleanup tasks.

Attachments (1)

kml_variable_fixes.diff (6.1 KB ) - added by Mateusz Łoskot 17 years ago.
Patch for the KML driver

Download all attachments as: .zip

Change History (13)

by Mateusz Łoskot, 17 years ago

Attachment: kml_variable_fixes.diff added

Patch for the KML driver

comment:1 by Mateusz Łoskot, 17 years ago

Owner: changed from warmerdam to Mateusz Łoskot
Status: newassigned

comment:2 by Mateusz Łoskot, 17 years ago

Partially applied (r12152). Work in progress, together with review and refactoring but first we need some test cases to control ourselfs :-)

comment:3 by Mateusz Łoskot, 16 years ago

Description: modified (diff)
Summary: Patch fixing variables scope in the KML driverKML driver review and cleanup

comment:4 by Mateusz Łoskot, 16 years ago

I committed a bunch of cleanup changes (r12864)

comment:5 by Mateusz Łoskot, 16 years ago

Improved CPLString usage (r12865)

comment:6 by Mateusz Łoskot, 16 years ago

More cleanup and refactoring: r12866, r12868, r12869, r12870

comment:7 by Mateusz Łoskot, 16 years ago

Yet another package of improvements: r12871, r12872, r12873

comment:8 by Mateusz Łoskot, 16 years ago

Next part of review changes: r12874, r12875

comment:9 by Mateusz Łoskot, 16 years ago

Fixed small bug in KML::eliminateEmpty() submitted in r12875 (r12877).

comment:10 by Mateusz Łoskot, 16 years ago

Print parsed KML tree only under debug run requested by setting environment CPL_DEBUG=ON (r12901)

comment:11 by Mateusz Łoskot, 16 years ago

Priority: highnormal

Putting it on the end of the 1.5.0 queue

comment:12 by hobu, 16 years ago

Resolution: fixed
Status: assignedclosed

Done for 1.5. We'll open a new bug for 1.6-related KML work.

Note: See TracTickets for help on using tickets.