Ticket #1828 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

WMS: Fix portability issues in WMS driver

Reported by: pvachon Owned by: warmerdam
Priority: normal Milestone: 1.5.0
Component: GDAL_Raster Version: svn-trunk
Severity: major Keywords: wms
Cc: warmerdam, dmorissette, nowakpl

Description

The attached patch fixes several issues in the WMS driver:

  • the redeclaration of int i within the same scope in for loops (issue on MIPSpro and MSVC++)
  • the usage of signed 1-bit bitfields (int m_something : 1) (issue on MIPSpro, and really is incorrect)
  • the round() function is a C99 function. With a compiler that is strict about adhering to "standards," C99 functions are not available when building C++ code. This was replaced with floor(x + 0.5)

Attachments

wms_fixes.patch Download (5.4 KB) - added by pvachon 6 years ago.
The patch for the WMS driver. To apply, copy to the frmts/wms/ directory and run patch -p1 < wms_fixes.patch

Change History

Changed 6 years ago by pvachon

The patch for the WMS driver. To apply, copy to the frmts/wms/ directory and run patch -p1 < wms_fixes.patch

Changed 6 years ago by warmerdam

  • cc warmerdam, dmorissette, nowakpl added
  • status changed from new to closed
  • resolution set to fixed

Patch applied ... thanks Phil.

Note: See TracTickets for help on using tickets.