Opened 17 years ago

Closed 17 years ago

#1828 closed defect (fixed)

WMS: Fix portability issues in WMS driver

Reported by: pvachon Owned by: warmerdam
Priority: normal Milestone: 1.5.0
Component: GDAL_Raster Version: svn-trunk
Severity: major Keywords: wms
Cc: warmerdam, Daniel Morissette, nowakpl

Description

The attached patch fixes several issues in the WMS driver:

  • the redeclaration of int i within the same scope in for loops (issue on MIPSpro and MSVC++)
  • the usage of signed 1-bit bitfields (int m_something : 1) (issue on MIPSpro, and really is incorrect)
  • the round() function is a C99 function. With a compiler that is strict about adhering to "standards," C99 functions are not available when building C++ code. This was replaced with floor(x + 0.5)

Attachments (1)

wms_fixes.patch​ (5.4 KB ) - added by pvachon 17 years ago.
The patch for the WMS driver. To apply, copy to the frmts/wms/ directory and run patch -p1 < wms_fixes.patch

Download all attachments as: .zip

Change History (2)

by pvachon, 17 years ago

Attachment: wms_fixes.patch​ added

The patch for the WMS driver. To apply, copy to the frmts/wms/ directory and run patch -p1 < wms_fixes.patch

comment:1 by warmerdam, 17 years ago

Cc: warmerdam Daniel Morissette nowakpl added
Resolution: → fixed
Status: new → closed

Patch applied ... thanks Phil.

Note: See TracTickets for help on using tickets.