Ticket #1681 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

Add cast to (unsigned char) in all isspace() calls

Reported by: dmorissette Owned by: chaitanya
Priority: normal Milestone: 1.6.1
Component: default Version: unspecified
Severity: normal Keywords:
Cc: mloskot, warmerdam

Description

Ticket #1678 pointed an issue with isspace() that requires casting of the char passed as argument to (unsigned char). The original issue has been fixed in the MITAB driver in ticket 1678, but there are 28 other places using isspace() in the current trunk version of GDAL that may need to be fixed as well (see attached list).

The issue is explained here:  http://www.greenend.org.uk/rjk/2001/02/cfu.html#ctypechar

This ticket is to track this.

Attachments

isspace.txt Download (2.0 KB) - added by dmorissette 5 years ago.
List of calls to isspace() in GDAL trunk

Change History

Changed 5 years ago by dmorissette

List of calls to isspace() in GDAL trunk

Changed 5 years ago by mloskot

Here is longer discussion about this issue:

 Assertion in .tab driver

Changed 4 years ago by warmerdam

  • milestone changed from 1.5.0 to 1.6.0

Changed 4 years ago by mloskot

  • cc mloskot added

Changed 3 years ago by hobu

This seems like a low intensity and low risk fix for 1.6.1 that just wasn't gotten to. If it can't be done for the 1.6.1 release, please kick it forward to 1.7 or future.

Changed 3 years ago by warmerdam

  • cc warmerdam added
  • owner changed from warmerdam to chaitanya

Chaitanya,

Please take care of this in 1.6 branch and trunk.

Changed 3 years ago by chaitanya

  • status changed from new to closed
  • resolution set to fixed

Modified trunk (r16865) and 1.6 (r16866).

Note: See TracTickets for help on using tickets.