Ticket #1414 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

world files and locale

Reported by: warmerdam Assigned to: warmerdam
Priority: high Milestone: 1.4.1
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords:
Cc: neteler

Description (Last modified by warmerdam)

When operating in the C locale, GDAL cannot read world files using commas in place of a period as the decimal point (ie. typical of the "de" locale for instance).

Please modify the worldfile reading code to support either "." or "," as the decimal place regardless of the working locale. Basically, use the CPLAtof() function in place of atof().

(see GDALReadWorldFile() in gdal/gcore/gdal_misc.cpp)

Make sure a test of this is added to the test suite.

Change History

01/29/07 00:12:00 changed by warmerdam 

I'm working on this one tonight.

01/29/07 00:28:24 changed by warmerdam 

I have added a CPLAtofM() in cpl_strtod.cpp which accepts either "," or "." 
regardless of locale.  It turns out that CPLAtof() only accepts "." regardless
of locale. 

Also added this into GDALReadWorldFile() in gdal_misc.cpp, and also the
.tab reader and the RPC metadata reading. 

Also added a test for this functionality in autotest/gdrivers/png.py via
the new test.wld mixed locale file in data.

All changes are in trunk.  I'm considering backporting to 1.4.x.

01/29/07 01:11:03 changed by warmerdam 

I have confirmed correct operation on windows, but attempts to merge have
been so far unsuccessful.  The changes are in:

 -r 10716:10712

Revisit tomorrow...

03/27/07 00:00:19 changed by warmerdam

  • description changed.
  • milestone set to 1.4.1.

03/27/07 00:00:39 changed by warmerdam

  • description changed.

03/28/07 22:33:07 changed by warmerdam

  • status changed from assigned to closed.
  • resolution set to fixed.

Patch backported to 1.4 branch.