Opened 13 years ago

Closed 11 years ago

#1242 closed defect (fixed)

OGDI needs PROJ headers

Reported by: kyngchaos@… Owned by: warmerdam
Priority: high Milestone: 1.5.4
Component: ConfigBuild Version: unspecified
Severity: major Keywords: ogdi
Cc:

Description (last modified by warmerdam)

In doing some more odd build situations, I found that OGDI (both raster and vector) needs the PROJ headers. I had PROJ built into it's own folder, isolated from everything else, so it's not in any other header path that might happen to be in common/default paths. OGDI couldn't find projects.h.

For frmts/ogdi/gnumakefile and ogr/ogrsf_frmts/ogdi/gnumakefile, I added $(PROJ_INCLUDE) to CPPFLAGS and OGDI is happy.

Attachments (2)

GNUmakefile.patch (301 bytes) - added by kyngchaos 12 years ago.
for GDAL frmt
GNUmakefile.2.patch (340 bytes) - added by kyngchaos 12 years ago.
OGR frmt makefile

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by kyngchaos

Attachment: GNUmakefile.patch added

for GDAL frmt

Changed 12 years ago by kyngchaos

Attachment: GNUmakefile.2.patch added

OGR frmt makefile

comment:1 Changed 12 years ago by kyngchaos

Trying to move this along - here are patches for the OGDI format makefiles. The should be good for both 1.4.2 and trunk.

comment:2 Changed 11 years ago by warmerdam

Component: defaultConfigBuild
Description: modified (diff)
Keywords: ogdi added
Priority: highesthigh
Severity: blockermajor
Status: newassigned

comment:3 Changed 11 years ago by warmerdam

Description: modified (diff)

comment:4 Changed 11 years ago by warmerdam

I believe the provided changes will only work when --with-static-proj is used to set the PROJ_INCLUDE macro. This is not the default build configuration. Also, a default build of OGDI will supply it's own PROJ.4 include files.

comment:5 in reply to:  4 Changed 11 years ago by kyngchaos

Then, is there some way to add PROJ_INCLUDE to OGDI_INCLUDE when proj_static is used? I hate to be so picky about this, but GDAL configuration should take into account "non-default" builds. Especially this one - why duplicate PROJ for OGDI when I have a PROJ already?

comment:6 Changed 11 years ago by warmerdam

Milestone: 1.5.4
Resolution: fixed
Status: assignedclosed

William,

Well, your patch will effectively handle the case of --with-static-proj - at least as long as OGDI is built with the same PROJ as GDAL which we pretty much have to assume.

I'm going to apply the patch, but I don't feel that it is by any means a comprehensive solution. I think the proper solution would be for ogdi to provide an ogdi-config script which handled providing the PROJ (and any other required) include paths. Alternatively, the public OGDI stuff really should not include proj. But I'm loath to do much major maintenance on OGDI these days.

Patches applied in trunk (r15878), 1.6 (r15879) and 1.5 (r15880).

Note: See TracTickets for help on using tickets.