Opened 13 years ago

Closed 13 years ago

#481 closed defect (fixed)

Redline doesn't work with commercial layers

Reported by: liuar Owned by: liuar
Priority: P2 Milestone: Future
Component: Widgets Version: 2.0
Severity: Major Keywords:
Cc: Browser: All
External ID: Operating System: All
state: Committed

Description

  1. Open a Map with Google Street Map
  2. Click Redline


Result: Error - Invalid argument supplied for foreach()
Expected: Work normally like without commercial layers

Attachments (1)

RedlinePatch.patch (446 bytes ) - added by liuar 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by liuar, 13 years ago

The original logic to find the top most map name has a potential issue: since commercial layers have lots of limitation, if maps[maps.length - 1] is a commercial layer, then following steps to deal with normal maps will get into trouble.

In the patch I replace the implementation with

this.getMapLayer().getMapName();

to get current map's name, which can guarantee the map is not a commercial layer.

comment:2 by liuar, 13 years ago

Hi Jackie,

Would you please review the patch and check if the new logic is right?

Regards,
Arthur

by liuar, 13 years ago

Attachment: RedlinePatch.patch added

comment:3 by jng, 13 years ago

Patch looks fine

comment:4 by liuar, 13 years ago

Resolution: fixed
state: NewCommitted
Status: newclosed

Thanks.

Note: See TracTickets for help on using tickets.