Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#347 closed defect (fixed)

GLOB: 4 new widgets EN strings are not localized yet

Reported by: christinebao Owned by: Christine Bao
Priority: P2 Milestone: Future
Component: Widgets Version: 1.1.1
Severity: Major Keywords:
Cc: Jenny He Browser: All
External ID: 1284495 Operating System: All
state: Committed

Description

The following new widgets don't put resource string into resource file, causing defect in localization:
Feature Info
Query
Theme
Redline

Please refer to the attached screen shot of Feature Info.

Attachments (4)

NoTranslate.JPG (93.7 KB ) - added by christinebao 14 years ago.
GlobNewWidgets.patch (32.7 KB ) - added by christinebao 14 years ago.
DropDownMenuLocalize.patch (9.4 KB ) - added by christinebao 14 years ago.
LocalePatch.patch (19.3 KB ) - added by chrisclaydon 14 years ago.

Download all attachments as: .zip

Change History (16)

by christinebao, 14 years ago

Attachment: NoTranslate.JPG added

comment:1 by christinebao, 14 years ago

comment:2 by christinebao, 14 years ago

Tech diagnosis:
The resource strings of the widgets (FeatureInfo, Query, Theme, Redline) are hard coded in php, and not put into resource file (usion\text\en). To fix this defect, those resource strings should be moved into resource file, so that localize team can translate them.

by christinebao, 14 years ago

Attachment: GlobNewWidgets.patch added

comment:4 by christinebao, 14 years ago

Resolution: fixed
state: NewCommitted
Status: newclosed

Thanks Arthur for reviewing. Commit the patch for fixing this defect.

by christinebao, 14 years ago

Attachment: DropDownMenuLocalize.patch added

comment:5 by christinebao, 14 years ago

Attach http://trac.osgeo.org/fusion/attachment/ticket/347/DropDownMenuLocalize.patch for fixing the drop-down menus of Theme, Query and Redline.

comment:6 by liuar, 14 years ago

Reviewed, please submit the code. Thanks.

comment:7 by christinebao, 14 years ago

The code is submitted. Thanks for reviewing.

comment:8 by christinebao, 14 years ago

QA found another defect: in Linux the texts of these four widgets are missing. Related defect 1290611: Linux: The button shows wrong in the flexible web layout.

This is because the new line is different in Linux and Windows, causing the resource file (en) not correct in Linux.
To fix this defect, please replace the MgDev\OS\Oem\fusion\text\en with the one created in Linux.

Perform test in Linux:

  1. Replace the en resource file.
  2. Restart web server.
  3. Open FeatureInfo, Query, Theme and Redline widgets, check the text of buttons and labels.

comment:9 by christinebao, 14 years ago

Commit r2034 to fix the above problem.

by chrisclaydon, 14 years ago

Attachment: LocalePatch.patch added

comment:10 by chrisclaydon, 14 years ago

Added LocalePatch.patch to address problems with passing locale using the wrong case, not at all, or hardcoded to 'en'.

comment:11 by chrisclaydon, 14 years ago

Committed to 2.2gp sandbox stream with submission:

http://trac.osgeo.org/fusion/changeset/2154

Reviewed by Bruce Dechant

Note: See TracTickets for help on using tickets.