Opened 14 years ago

Closed 14 years ago

#330 closed defect (fixed)

Theme doesn't work on the map with commercial layers

Reported by: liuar Owned by: chrisclaydon
Priority: P2 Milestone: Future
Component: Widgets Version: 1.1.1
Severity: Major Keywords:
Cc: jenny.he@… Browser: All
External ID: Operating System: All
state: Approved

Description

Steps:

  1. Open one flexible web layout with commercial layers.
  2. Theme -> Set theme rule -> Apply

Results: Nothing changed in web layout.

Expected results: Map should display as Theme rule.

Attachments (1)

ticket #330.patch (825 bytes ) - added by liuar 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by liuar, 14 years ago

Cc: jenny.he@… added

comment:2 by liuar, 14 years ago

Apply theme invoke reloadMap in Generic.js which will reload all the commercial layers in current map. In loadMap method in Generic.js at line 77, if a commericial layer already exsits, it will be destroy then create a new one . But after the layer destroyed, the point to the layer is not set to null which will ignore the layer re-creation and cause a exception like "null reference exception" when register events to this.oLayerOL.events.

by liuar, 14 years ago

Attachment: ticket #330.patch added

comment:3 by liuar, 14 years ago

Fix typo of my first commet section.

Apply theme invokes reloadMap in Generic.js which will reload all the commercial layers in current map. In loadMap method in Generic.js at line 77, if a commercial layer already exists, it will be destroied then create a new one . But after the layer destroyed, the pointer to the layer is not set to null which will ignore the layer’s re-creation and will cause an exception like "null reference exception" when register events to this.oLayerOL.events.

comment:4 by zjames, 14 years ago

state: NewApproved

ok, please commit.

comment:5 by tomfukushima, 14 years ago

Owner: changed from liuar to chrisclaydon

Chris can you commit this?

comment:6 by chrisclaydon, 14 years ago

Resolution: fixed
Status: newclosed

Submitted patch and converted the tabs it contains to spaces. In the future, please try to ensure that all tabs are converted to spaces before creating patches. Thx.

http://trac.osgeo.org/fusion/changeset/1983

Note: See TracTickets for help on using tickets.