FDO RFC 50 - Extend FDO API to Select from Multiple Classes and Select Joins
This page contains a request for comments document (RFC) for the FDO Open Source project. More FDO RFCs can be found on the RFCs page.
Status
| RFC Template Version | 1.0 |
| Submission Date | Jun. 02 2010 |
| Last Modified | Romica Dascalescu (June 23, 2010) |
| Author | Romica Dascalescu |
| Contibutors | Orest Halustchak, Greg Boone |
| RFC Status | Adopted |
| Implementation Status | Complete |
| Proposed Milestone | 3.6.0.0 |
| Assigned PSC guide(s) | Orest Halustchak |
| Voting History | July 22, 2010 |
| +1 | Jackie, Orest, Jason, Greg, Haris |
| +0 | |
| -0 | |
| -1 |
Motivation
It is a common requirement for applications to join classes together so that they can process related information that is spread across more than one class, e.g. properties stored in one class and geometry in another class. This can be for modeling purposes such as when geometry in one class is shared between separate feature classes or when properties from another class are needed for rendering purposes. Currently this is achieved either by using client-side join processing as in MapGuide or for RDBMS sources, by defining views as the physical level and exposing them as feature classes at the FDO API level. While these techniques are useful, the first results in very poor performance compared to a native join if the classes come from the same data store and the data store can do native joins as is possible with RDBMS-based providers. Using views is common as well, but requires the user to do this at the physical data store level. Finally, users could use SQL pass-through for providers that support it but that has issues because again the user is dealing with physical schema rather than FDO classes and the result is not a feature class.
This RFC adds the ability to create joined selects using the FDO API directly rather than using the workarounds described above. This adds more power and flexibility to the FDO API for applications that need that capability. This enhancement will be optional for providers and a capabilities function is included for an application to determine if a provider supports it.
Overview
Implementing this new select is optional for all providers, for now we will start with the SQLite provider and in the future we can extend it to other providers as needed. We expect the RDBMS-based providers to support this over time.
The idea is to add support in FDO API for selecting from multiple classes and get a feature reader back.
We have a few options from which we can chose in order to achieve our goal:
- Add a new select command e.g. FdoIJoinSelect derived from FdoISelect, add a new command type and caller needs to ensure that command exist in the provider command capabilities before calling this interface. A small improvement here we can add two classes FdoIJoinSelect (the interface having only pure methods) and FdoJoinSelect (having a default implementation of the new method). All providers can use the class with a base implementation and in the future in case we want to add a new method we just add a default implementation in FdoJoinSelect, however this adds more complexity to the API since developer would be confused which class should use as base class in his implementation.
- Pros: will not change the FdoISelect command, all other providers do not have to change anything on their side, and only in case a provider wants to support this command it has to implement it and expose it as supported.
- Cons: We add a new command and a new type command, we already have a FdoIExtendedSelect for scrollable readers and users can be confused by those two commands. This will add more complexity in the API.
- Pros: will not change the FdoISelect command, all other providers do not have to change anything on their side, and only in case a provider wants to support this command it has to implement it and expose it as supported.
- Enhance FdoISelect, add a new method GetJoinCriteria(). Create an FdoSelect base class and add default implementer for this method. Then each provider would be changed to base their select command implementations on FdoSelect instead of FdoISelect. To allow the join functionality to be fully integrated, two new capability functions will be added to the FDO FdoIConnectionCapabilities Interface so that applications can determine if a provider supports the join criteria and supported join types. These new capabilities would be named: SupportsJoins() & GetJoinTypes(). Again, if future enhancements are ever made to FdoISelect, the need to change each provider would be eliminated.
- Pros: this solution will not add more complexity to the API.
- Cons: We need to change all the providers leading to a big effort from everyone.
- Pros: this solution will not add more complexity to the API.
- Enhance FdoISelect, add a new method GetJoinCriteria() with the default implementation of the method throwing an exception, also add two new methods used to set alias for the main class: SetAlias() & GetAlias() having empty implementation (no exception will be thrown here). Providers which want to implement these new methods must override them and provide a detailed implementation. Even though FdoISelect is declared as interface we do not have real interfaces in the FDO C++ API, and abstract methods can co-exist with those that have a default implementation. A good example here are the locking methods on the select command. Most providers do not support locking and have to provide an empty implementation (usually to throw an exception), creating more code on provider side. A better plan would have provided a default implementation in the FdoISelect base class. Following this idea, this alternative will just modify the FdoISelect base class, allowing providers that that will not support joins to remain unchanged. These providers will inherit the default implementation. Looking at FdoISelect there are already two methods which provide default implementation: AddRef() and Release(), so adding default implementation for the new method will not be something totally new. As with option 2 above: Two new capability functions will be added to the FDO FdoIConnectionCapabilities Interface so that applications can determine if a provider supports the join criteria, supported join types and sub-selects. These new capabilities would be named: SupportsJoins(), GetJoinTypes() & SupportsSubSelects(). A few other changes must be done in order to handle sub-selects.
- Pros: this solution will not add more complexity to the API, we do not need to change any provider.
- Cons: None.
- Pros: this solution will not add more complexity to the API, we do not need to change any provider.
Proposed Solution
The last option seems to be the best solution since will not enforce other providers to add a blank implementation for the new method and also will not add a new command. We avoid having two select commands one "extended" and one "join" this way we also eliminate a confusion which might show-up in commands naming. Also it opens a different approach to update a base class without changing all providers to add a blank implementation.
The new methods added on FdoISelect will have a default implementation throwing an exception or empty implementation:
class FdoISelect : public FdoIBaseSelect
{
/// new added methods
/// \brief
/// Gets the join criteria collection.
///
/// \return
/// Returns the collection.
///
FDO_API virtual FdoJoinCriteriaCollection* GetJoinCriteria()
{
throw FdoException::Create(FdoException::NLSGetMessage(FDO_NLSID(FDO_3_NOTIMPLEMENTED)));
}
/// \brief
/// Gets the alias used for the main feature class.
///
/// \return
/// Returns the identifier.
///
FDO_API virtual FdoString* GetAlias()
{
return NULL;
}
/// \brief
/// Sets the alias used for the main feature class.
///
/// \return
///
FDO_API virtual void SetAlias(FdoString* alias)
{
}
}
Handling Joins
Below we define new classes to define and use a join criteria used in the join select.
class FdoJoinCriteria : public FdoIDisposable
{
protected:
/// Constructs a default instance of a parameter.
FdoJoinCriteria();
/// Constructs an instance of a parameter using the specified arguments.
FdoJoinCriteria(FdoIdentifier* joinClass, FdoJoinType joinType);
/// Constructs an instance of a parameter using the specified arguments.
FdoJoinCriteria(FdoIdentifier* joinClass, FdoJoinType joinType, FdoFilter* filter);
/// Constructs an instance of a parameter using the specified arguments.
FdoJoinCriteria(FdoString* alias, FdoIdentifier* joinClass, FdoJoinType joinType);
/// Constructs an instance of a parameter using the specified arguments.
FdoJoinCriteria(FdoString* alias, FdoIdentifier* joinClass, FdoJoinType joinType, FdoFilter* filter);
public:
/// Constructs a default instance of a join criteria.
FDO_API static FdoJoinCriteria* Create();
/// Constructs a full defined instance of a join criteria.
/// In this case Alias = joinClass->GetName().
FDO_API static FdoJoinCriteria* Create(FdoIdentifier* joinClass,
FdoJoinType joinType);
/// Constructs a full defined instance of a join criteria.
/// In this case Alias = joinClass->GetName().
FDO_API static FdoJoinCriteria* Create(FdoIdentifier* joinClass,
FdoJoinType joinType,
FdoFilter* filter);
/// Constructs a full defined instance of a join criteria.
FDO_API static FdoJoinCriteria* Create(FdoString* alias,
FdoIdentifier* joinClass,
FdoJoinType joinType);
/// Constructs a full defined instance of a join criteria.
FDO_API static FdoJoinCriteria* Create(FdoString* alias,
FdoIdentifier* joinClass,
FdoJoinType joinType,
FdoFilter* filter);
/// Returns the alias name for the join criteria class
FDO_API FdoString* GetAlias();
/// Sets the alias name for the join criteria class
FDO_API void SetAlias(FdoString* value);
/// Returns true if there is an alias set and false if GetAlias() returns the join class
FDO_API bool HasAlias();
/// Returns the identifier of the right join class
FDO_API FdoIdentifier* GetJoinClass();
/// Sets the identifier of the right join class
FDO_API void SetJoinClass(FdoIdentifier* value);
/// Returns the join type, e.g. inner join, cross join, left join
/// using FdoJoinType_None in join criteria will generate an exception
FDO_API FdoJoinType GetJoinType() const;
/// Sets the join type, e.g. inner join, cross join, left join
FDO_API void SetJoinType(FdoJoinType value);
/// Returns the join filter, e.g. LEFT JOIN rclass ON(filter)
FDO_API FdoFilter* GetFilter();
/// Sets the join filter, e.g. LEFT JOIN rclass ON(filter)
FDO_API void SetFilter(FdoFilter* value);
};
/// Join type enumeration used to specify the join type
enum FdoJoinType
{
/// default join type. This value can be returned by the GetJoinTypes()
/// in case joins are not supported
/// rather than provider throw an exception can return this value
/// in case join are not supported (this is like NAN for doubles)
FdoJoinType_None = 0x00,
/// inner join
FdoJoinType_Inner = 0x01,
/// right outer join
FdoJoinType_RightOuter = 0x02,
/// left outer join
FdoJoinType_LeftOuter = 0x04,
/// full outer join
FdoJoinType_FullOuter = 0x08,
/// cross join (cartesian join)
/// can be used for cases like SELECT * FROM A, B
FdoJoinType_Cross = 0x10
};
In case user will try to use !FdoJoinType_None to define a FdoJoinCriteria, an exception will be thrown that's because !FdoJoinType_None is added just to define unsupported value for join type.
We need to add two new methods in connection capabilities: supports join selects (to avoid an exception when a user will try to use the new method from FdoISelect) and also supported join types which can be a collection or a value as OR between values, since all join types cannot be more than we can fit in a int32 using OR e.g.: val1|val2. We need to add an extra capability named SupportsSubSelects() since sub-select will be handled in filter side and applications might need a way to detect if it will allow users to create sub-selects in filter. GetJoinTypes() will return !FdoJoinType_None in case no join is supported.
Default implementation for GetJoinTypes() will return !FdoJoinType_None and SupportsJoins() will return false, since is not normal to throw exceptions when caller wants to get capabilities.
An exception will be thrown in case caller is passing a filter to a cross join criteria (FdoJoinType_Cross) and also an exception will be thrown in case caller is passing a NULL filter to all join criteria types except None and Cross.
class FdoIConnectionCapabilities
{
virtual bool SupportsJoins() const;
virtual FdoInt32 GetJoinTypes() const;
virtual bool SupportsSubSelects() const;
}
We also need a collection to be defined for join criteria:
class FdoJoinCriteriaCollection : public FdoCollection<FdoJoinCriteria, FdoCommandException>
{
public:
/// Default constructor
FDO_API static FdoJoinCriteriaCollection* Create();
/// Returns FdoJoinCriteria in case if found (based on name search).
/// This will throw an exception in case item is not found
FDO_API FdoJoinCriteria* GetItem(FdoString* alias);
/// Returns NULL in case FdoJoinCriteria was not found or FdoJoinCriteria found (based on name search).
FDO_API FdoJoinCriteria* FindItem(FdoString* alias);
/// Returns FdoJoinCriteria having the index.
FDO_API FdoJoinCriteria* GetItem(FdoInt32 index);
};
Note: Join criteria have a name which can be an alias (in case caller provided one) or the name of the class in case user did not provided an alias. Search in this collection by name will use only join criteria name in the search and will not check alias and name also, so in case caller uses an alias, he should use in filters only that alias in front of properties.
Join criteria will be used to generate join SQL commands, like:
SELECT p.FeatId AS xFID,p.Geometry,pxy.Name,pxy.X,pxy.Y,pex.NameB,pex.Link FROM p
INNER JOIN pxy ON(p.FeatId = pxy.FeatId)
INNER JOIN pex ON(pex.FID = pxy.FeatId)
WHERE p.FeatId >= 0;
Below we added some C++ code on how caller can use this new improvement to achieve above select statement:
FdoPtr<FdoISelect> sel = static_cast<FdoISelect*>(conn->CreateCommand(FdoCommandType_Select));
FdoPtr<FdoIdentifier> fcpoint = FdoIdentifier::Create(L"p");
sel->SetFeatureClassName(fcpoint); // set the main class
FdoPtr<FdoJoinCriteriaCollection> jcrit = sel->GetJoinCriteria();
FdoPtr<FdoIdentifier> jcCls1 = FdoIdentifier::Create(L"pxy");
FdoPtr<FdoFilter> flcr1 = FdoFilter::Parse(L"p.FeatId=pxy.FeatId");
FdoPtr<FdoJoinCriteria> jc1 = FdoJoinCriteria::Create(L"pxy", jcCls1, FdoJoinType_Inner, flcr1);
jcrits->Add(jc1);
FdoPtr<FdoIdentifier> jcCls2 = FdoIdentifier::Create(L"pex");
FdoPtr<FdoFilter> flcr2 = FdoFilter::Parse(L"pex.FID=pxy.FeatId");
FdoPtr<FdoJoinCriteria> jc2 = FdoJoinCriteria::Create(L"pex", jcCls2, FdoJoinType_Inner, flcr2);
jcrits->Add(jc2);
FdoPtr<FdoIFeatureReader> rdr = sel->Execute();
Selecting from Multiple Classes
We should be able to select from multiple classes and have filters applied on any class attributes. In order to be able to achieve that objective, we can use FdoISelect::GetJoinCriteria() and add all classes we want to select from. The filter must be based on properties from the selected classes and filter can be validated at run time when the whole select is built. Aliases can be used by calling SetAlias()/GetAlias() on the select interface, e.g. ClassName AS NewClassName.
The following sections will use some SQL examples just to illustrate things we are trying to achieve, each RBDMS-based provider will translate FDO selects in server side SQL depending of the server capabilities.
SELECT * FROM class1 AS p1 INNER JOIN class2 AS p2 ON(p1.ID=p2.FeatId) WHERE SPATIAL_COND(p1.GEOM, GEOM_VAL);
Below we added some C++ code on how caller can use this new improvement to achieve above select statement:
FdoPtr<FdoISelect> sel = static_cast<FdoISelect*>(conn->CreateCommand(FdoCommandType_Select));
FdoPtr<FdoIdentifier> fcname1 = FdoIdentifier::Create(L"class1");
sel->SetFeatureClassName(fcpoint); // set the main class
sel->SetAlias(L"p1");
FdoPtr<FdoJoinCriteriaCollection> jcrit = sel->GetJoinCriteria();
FdoPtr<FdoIdentifier> fcname2 = FdoIdentifier::Create(L"class2");
FdoPtr<FdoJoinCriteria> jc1 = FdoJoinCriteria::Create(L"p2", fcname2, FdoJoinType_Inner, L"p1.ID=p2.FeatId");
jcrits->Add(jc1);
FdoPtr<FdoFilter> filter = FdoFilter::Parse(L"Geometry INTERSECTS GeomFromText('CURVESTRING(...)')");
sel->SetFilter(filter);
FdoPtr<FdoIFeatureReader> rdr = sel->Execute();
Handle Sub-Selects
Below we define a new class to define sub-select used in the new select. In case a provider supports sub-selects the capability SupportsSubSelects() should return true.
/// \brief
/// The FdoSubSelectExpression class derives from FdoValueExpression and can be used with IN condition
/// to test if a property is in a range of values returned by this sub-select
class FdoSubSelectExpression : public FdoValueExpression
{
protected:
/// Constructs a default instance of an FdoSubSelectExpression.
FdoSubSelectExpression();
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
FdoSubSelectExpression(FdoIdentifier* className, FdoIdentifier* propertyName);
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
FdoSubSelectExpression(FdoIdentifier* className, FdoIdentifier* propertyName, FdoFilter* filter);
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
FdoSubSelectExpression(FdoIdentifier* className, FdoIdentifier* propertyName, FdoJoinCriteriaCollection* joinCritColl);
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
FdoSubSelectExpression(FdoIdentifier* className, FdoIdentifier* propertyName, FdoFilter* filter, FdoJoinCriteriaCollection* joinCritColl);
virtual ~FdoSubSelectExpression();
virtual void Dispose();
public:
/// \brief
/// Constructs a default instance of an FdoSubSelectExpression.
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API static FdoSubSelectExpression* Create();
/// \brief
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
///
/// \param className
/// Input class name
/// \param propertyName
/// Input property name
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API static FdoSubSelectExpression* Create(FdoIdentifier* className, FdoIdentifier* propertyName);
/// \brief
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
///
/// \param className
/// Input class name
/// \param propertyName
/// Input property name
/// \param filter
/// Input main filter
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API static FdoSubSelectExpression* Create(FdoIdentifier* className, FdoIdentifier* propertyName, FdoFilter* filter);
/// \brief
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
///
/// \param className
/// Input class name
/// \param propertyName
/// Input property name
/// \param joinCritColl
/// Input join Criteria collection
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API static FdoSubSelectExpression* Create(FdoIdentifier* className, FdoIdentifier* propertyName, FdoJoinCriteriaCollection* joinCritColl);
/// \brief
/// Constructs an instance of an FdoSubSelectExpression using the specified arguments.
///
/// \param className
/// Input class name
/// \param propertyName
/// Input property name
/// \param filter
/// Input main filter
/// \param joinCritColl
/// Input join Criteria collection
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API static FdoSubSelectExpression* Create(FdoIdentifier* className, FdoIdentifier* propertyName, FdoFilter* filter, FdoJoinCriteriaCollection* joinCritColl);
/// \brief
/// Gets the name of the class.
///
/// \return
/// Returns the name of the class
///
FDO_API FdoIdentifier* GetFeatureClassName();
/// \brief
/// Sets the name of the class.
///
/// \param value
/// Input the name of the class
///
/// \return
/// Returns nothing
///
FDO_API void SetFeatureClassName(FdoIdentifier* value);
/// \brief
/// Gets the name of the property.
///
/// \return
/// Returns the name of the property
///
FDO_API FdoIdentifier* GetPropertyName();
/// \brief
/// Sets the name of the property.
///
/// \param value
/// Input the name of the property
///
/// \return
/// Returns nothing
///
FDO_API void SetPropertyName(FdoIdentifier* value);
/// \brief
/// Gets join criteria collection.
///
/// \return
/// Returns FdoJoinCriteriaCollection
///
FDO_API FdoJoinCriteriaCollection* GetJoinCriteria();
/// \brief
/// Sets the join criteria collection.
///
/// \param value
/// Input FdoJoinCriteriaCollection.
///
/// \return
/// Returns nothing
///
FDO_API void SetJoinCriteria(FdoJoinCriteriaCollection* value);
/// \brief
/// Gets the join filter.
///
/// \return
/// Returns FdoFilter
///
FDO_API FdoFilter* GetFilter();
/// \brief
/// Sets the join filter.
///
/// \param value
/// Input FdoFilter.
///
/// \return
/// Returns nothing
///
FDO_API void SetFilter(FdoFilter* value);
/// \brief
/// Overrides FdoFilter.Process to pass the FdoSubSelectExpression to the appropriate
/// filter processor operation.
///
/// \param p
/// Input filter processor
///
/// \return
/// Returns nothing
///
FDO_API void Process(FdoIExpressionProcessor* p);
/// \brief
/// Returns the well defined text representation of this expression.
///
/// \return
/// Returns the well defined text string
///
FDO_API FdoString* ToString();
/// \brief
/// Gets Item Expression Type.
///
/// \return
/// Returns FdoItemExpressionType (FdoItemExpressionType_SubSelectExpression)
///
FDO_API FdoItemExpressionType GetExpressionType() const;
/// \brief
/// Converts the filter expression to its well defined text representation.
///
/// \return
/// Returns well defined text string
///
FdoString* ToStringInternal( FdoIdentifierCollection *pIdCol );
private:
FdoIdentifier* m_className;
FdoIdentifier* m_propertyName;
FdoFilter* m_filter;
FdoJoinCriteriaCollection* m_joinCritColl;
};
FDO parser will be modified and we will add new keywords: SELECT, JOIN, JOINNONE, JOININNER, JOINRIGHTOUTER, JOINLEFTOUTER, JOINFULLOUTER, JOINCROSS, used to generate well defined text representation of this expression. Below there is a small example on how well defined text representation of this expression will look. SELECT, JOIN will play the same role as IN, the role of an operator and not the role of a function. JOINNONE, JOININNER, JOINRIGHTOUTER, JOINLEFTOUTER, JOINFULLOUTER, JOINCROSS will be type of join and at parse time will be converted to FdoJoinType.
FdoPtr<FdoFilter> flt = FdoFilter::Parse(L"FeatId IN ( SELECT (CLS, (PROP*30) AS P1, P1 >= 45, JOIN(CLS2 AS CC, JOININNER, CLS.P1=CC.P2), JOIN(CLS2 AS CC2, JOINRIGHTOUTER, CLS.P1=CC2.P2)) )");
FdoString* str = flt->ToString();
printf ("%ls\n", str);
// we get on the screen
//
// FeatId IN (SELECT(CLS,( PROP*30 ) AS P1,P1 >= 45,JOIN(( CLS2 ) AS CC,JOININNER,CLS.P1 = CC.P2),JOIN(( CLS2 ) AS CC2,JOINRIGHTOUTER,CLS.P1 = CC2.P2)))
Named sub-select will be used to generate SQL commands, like:
SELECT * FROM point WHERE FeatId IN (SELECT pt.FeatId FROM pt WHERE pt.FeatId >= 2 AND SPATIAL_COND(pt.GEOM, GEOM_VAL));
Below we added some C++ code on how caller can use this new improvement to achieve above select statement:
FdoPtr<FdoISelect> sel = static_cast<FdoISelect*>(conn->CreateCommand(FdoCommandType_Select));
FdoPtr<FdoIdentifier> fcpoint = FdoIdentifier::Create(L"point");
sel->SetFeatureClassName(fcpoint); // set the main class
FdoPtr<FdoFilter> filter= FdoFilter::Parse(L"FeatId IN(SELECT(pt, pt.FeatId, pt.FeatId>=2 AND Geometry INTERSECTS GeomFromText('CURVESTRING(...)')))");
sel->SetFilter(filter);
FdoPtr<FdoIFeatureReader> rdr = sel->Execute();
In order to be able to support sub-selects for IN operator we need add an additional constructor and two new methods (get/set)to FdoInCondition.
/// This way we allow the FDO IN() operator to handle sub-selects.
class FdoInCondition : public FdoSearchCondition
{
/// new additions to this class
protected:
FdoInCondition(FdoIdentifier* propertyName, FdoSubSelectExpression* subSel);
public:
/// \brief
/// Constructs an instance of an FdoInCondition using the specified arguments.
///
/// \param propertyName
/// Input property name
/// \param subSel
/// Input sub-select
///
/// \return
/// Returns FdoInCondition
///
FDO_API static FdoInCondition* Create(FdoIdentifier* propertyName, FdoSubSelectExpression* subSel);
/// \brief
/// Gets the sub-select expression.
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API FdoSubSelectExpression* GetSubSelect();
/// \brief
/// Sets the sub-select expression.
///
/// \return
/// Returns FdoSubSelectExpression
///
FDO_API void SetSubSelect(FdoSubSelectExpression* value);
};
As new additions, the FDO API will define three new classes:
- FdoJoinCriteria
- FdoJoinCriteriaCollection
- FdoSubSelectExpression
and two enumerations
- FdoItemExpressionType
- FdoJoinType
The API will also be updated to include two new command capabilities in order to be able to detect if the method is supported by the provider. Otherwise caller might get exceptions from the default implementation.
- SupportsJoins
- GetJoinTypes
- SupportsSubSelects
At FdoISelect::Execute time a feature reader will be returned, even though there might be cases when the join class returned by the reader will not contain a primary property or a geometry property. In cases where select commands do not provide a property selection list, all properties should be added to the feature class reader built at runtime. In cases where applications request a subset of properties, only those properties should be added to the feature class, even if that means the returned feature class might then contain no identity properties or geometry properties. In the worst case, a provider implementation can add all identity properties from the selected classes to the resulting identity property list of the joined class definition. Also, in case there is no way to return an identity property, providers can add a non-identity property to the identity property collection of the returned class as a shortcut to allow a primary property to be defined. (NOTE that the returned class will be read-only since there is no way to know if the resulting class can be updated.)
FdoISelectAggregates interface will be updated in the same manner in order to allow performing aggregates selects having sub-selects in the filter side.
Update and delete commands will not be changed to allow using this new expression as a value, however we can update those commands doing a similar RFC in the future if is needed.
Small improvements in FDO
Handling FDO expressions to avoid dynamic casts
In the current API in order to make a difference between FdoIdentifier and FdoComputedIdentifier we need to use dynamic cast and that’s not too fast. There is a simple way to avoid many dynamic casts by adding a new abstract method in FdoExpression named GetExpressionType(). All main derivate classes from FdoExpression need to return a type without adding a new parameter this way we avoid increasing the memory consumption by FDO expression objects. A new enumeration will be added, see below, and classes like FdoIdentifier will have to implement this method.
/// The FdoExpressionType enumeration defines the expression types available.
enum FdoItemExpressionType
{
/// Identifier e.g. PROP
FdoItemExpressionType_Identifier,
/// Identifier e.g. PROP*5 AS EXP
FdoItemExpressionType_ComputedIdentifier,
/// Identifier e.g. SELECT PROP FROM CLS WHERE COND
FdoItemExpressionType_SubSelectExpression,
/// Parameter e.g. :PROP
FdoItemExpressionType_Parameter,
/// Function e.g. AVG()
FdoItemExpressionType_Function,
/// Expression e.g. A+B
FdoItemExpressionType_BinaryExpression,
/// Expression e.g. -A
FdoItemExpressionType_UnaryExpression,
/// Data value e.g. 12, 12.4 'text'
FdoItemExpressionType_DataValue,
/// Geometry e.g. 12, 12.4 'text'
FdoItemExpressionType_GeometryValue
};
class FdoIdentifier : public FdoExpression
{
/// Returns FdoItemExpressionType
FDO_API virtual FdoItemExpressionType GetExpressionType() const
{
return FdoItemExpressionType_Identifier;
}
}
Update the FDO Filter to handle custom names
FDO filter parser needs to be updated since we support only Class.Property e.g.: "A.BB >=10". We need to support also formats like:
- Class."Property"
- "Class".Property
- "Class"."Property"
This change is required in order to be able to support properties names having special characters, like: myClass."My Property" > 10. This change will not involve any API change and will be done like a bug fix.
FDO filter parser needs to be updated also to support sub-selects in filter side e.g. "FeatId IN (SELECT(CLS,( PROP*30 ) AS P1,P1 >= 45,JOIN(( CLS2 ) AS CC,JOININNER,CLS.P1 = CC.P2),JOIN(( CLS2 ) AS CC2,JOINRIGHTOUTER,CLS.P1 = CC2.P2)))". FDO expression parser needs to be updated to support sub-selects expressions in order to be used for other things like update/insert.
Managed FDO API
The FDO Managed Interfaces will be updated in a similar manner to reflect the proposed changes.
Provider Implementation
Initially, we need this for SQLite provider. Other provider developers can add it and use it as needed. The providers which decide to use this new select, needs to implement the new method from the FdoISelect and return the right command capabilities.
Test Plan
Run existing FDO core unit tests and expand SQLite unit tests to test the proposed enhancements defined above.
Future Enhancements
If needed, similar extensions can be done to FDO Update, Delete, and other commands that use filters so that they can take advantage of sub-selects.
Other providers can be enhanced over time to implement these changes as needed.
Funding / Resources
Autodesk to provide resources / funding.
