SHP provider crash in import/export of the corrupted or invalid spatial index file(idx)

[stevenxu]

The corrupted or invalid spatial index file can lead unhandled FdoException in destructor of class "ShpFileSet", as following:

\Providers\SHP\Src\Provider\ShpFileSet.cpp

ShpFileSet::~ShpFileSet (void) {

if ( mFilesExist ){

ReopenFileset( FdoCommonFile::IDF_OPEN_READ );

.....

}

The function "ReopenFileset" will open the idx file and generate a FdoException when the idx file is invalid. This unhandled exception can lead application crash.

You can modify the idx file deliberately to reproduce this problem. For example, use text editor to modify the first characters of this file as any others.

[stevenxu]

The attachment contains the corrupted idx file.

[stevenxu]

Made two change:

1. Catch the exception in the destructor of ShpFileSet
2. Remove the invalid idx file and rebuild the spatial index file when member function "GetSpatialIndex" fail to open it at the first time.

Fixed in branch with submission ​https://trac.osgeo.org/fdo/changeset/4243

[stevenxu]

Fixed in trunk with submission ​https://trac.osgeo.org/fdo/changeset/4249